Skip to content

src: include filesystem root in package search - #64909

Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner6
Closed

src: include filesystem root in package search#64909
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner6

Conversation

@Archkon

@Archkon Archkon commented Aug 1, 2026

Copy link
Copy Markdown

Move the root termination check after processing the current directory so node --run can find package.json and node_modules/.bin at the filesystem root.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 1, 2026
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (a4aa3c0) to head (9f54a09).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64909      +/-   ##
==========================================
+ Coverage   90.28%   90.29%   +0.01%     
==========================================
  Files         760      760              
  Lines      247061   247063       +2     
  Branches    46592    46585       -7     
==========================================
+ Hits       223058   223088      +30     
+ Misses      15491    15448      -43     
- Partials     8512     8527      +15     
Files with missing lines Coverage Δ
src/node_task_runner.cc 88.88% <100.00%> (-0.44%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Move the root termination check after processing the current directory
so node --run can find package.json and node_modules/.bin at the
filesystem root.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon

This comment was marked as spam.

@aduh95 aduh95 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants