Skip to content

test: replace forEach with for...of in test-require-resolve-invalid-paths - #67128

Open
rraulg5 wants to merge 1 commit into
nodejs:mainfrom
rraulg5:main
Open

rraulg5 wants to merge 1 commit into
nodejs:mainfrom
rraulg5:main

Conversation

@rraulg5

@rraulg5 rraulg5 commented Oct 29, 2026

Copy link
Copy Markdown

Replaces forEach with for...of loop in the invalid paths test, which is clearer stack traces, works with await, no per-iteration closure.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@rraulg5
rraulg5 force-pushed the main branch 3 times, most recently from ff31851 to 1e4f7a7 Compare October 29, 2026 23:14
@rraulg5 rraulg5 changed the title test: replace forEach with for...of in test-require-resolve-invalid-paths.js test: replace forEach with for...of in test-require-resolve-invalid-paths Oct 29, 2026
Signed-off-by: Raul Garcia <rraulg5@gmail.com>
@Ethan-Arrowood Ethan-Arrowood added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 29, 2026
@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (8d514c7) to head (8554a4a).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #67128   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files         797      797           
  Lines      278791   278791           
  Branches    53617    53623    +6     
=======================================
+ Hits       252756   252779   +23     
+ Misses      16386    16377    -9     
+ Partials     9649     9635   -14     

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue PRs queued for automated landing through the Commit Queue. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants