Skip to content

Conversation

@icyJoseph
Copy link
Contributor

@icyJoseph icyJoseph commented Nov 24, 2025

Description

Whenever the DigitalOcean logo renders on screen, it causes hydration errors. This happens only on the meta/next-16 branch.

Screenshot 2025-11-24 at 23 26 26

I am not seeing this on main, so it is likely a new React validation that comes into place w/ next@16. It shouldn't hurt to merge anyway.

Validation

Any page with the DigitalOcean logo prints errors in dev mode.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 24, 2025 10:25pm

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@icyJoseph icyJoseph marked this pull request as ready for review November 24, 2025 22:31
@icyJoseph icyJoseph requested a review from a team as a code owner November 24, 2025 22:31
@araujogui araujogui requested a review from Copilot November 24, 2025 22:58
Copilot finished reviewing on behalf of araujogui November 24, 2025 22:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes hydration errors in the DigitalOcean logo component that occur with Next.js 16 by consolidating multi-line SVG path data into single lines. React 19/Next.js 16 introduced stricter hydration validation that can detect whitespace differences in attribute values between server-side and client-side rendering, causing errors when SVG d attributes span multiple lines.

Key Changes:

  • Consolidated all multi-line SVG path d attributes in the DigitalOcean logo to single lines
  • Replaced newlines with spaces to preserve path data integrity
  • All 12 <path> elements with complex path data were reformatted for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller enabled auto-merge November 27, 2025 14:59
@avivkeller avivkeller added this pull request to the merge queue Nov 27, 2025
Merged via the queue into nodejs:main with commit 9a25402 Nov 27, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants