feat(`tape-to-node-test`): introduce by AugustinMauroy · Pull Request #296 · nodejs/userland-migrations

AugustinMauroy · 2025-12-10T10:50:27Z

Related issue

Close #260

Co-authored-by: Bruno Rodrigues <swe@brunocroh.com>

ljharb

(btw the diff would read cleaner if it was "output" instead of "expected", because then "input" would be sorted before "output" instead of the reverse)

some of my comments apply on all the input/expected combos, so i'll post this now before being exhaustive

AugustinMauroy · 2026-01-17T16:19:58Z

(btw the diff would read cleaner if it was "output" instead of "expected", because then "input" would be sorted before "output" instead of the reverse)

some of my comments apply on all the input/expected combos, so i'll post this now before being exhaustive

the input/expect structure isn't chose by us it's the design of the codemod tool

Co-authored-by: Bruno Rodrigues <swe@brunocroh.com>

AugustinMauroy · 2026-01-21T20:16:07Z

that's fine, but can the PR be marked draft in the meantime? a green PR is mergeable, and with this todo i don't think that's accurate.

i have updated the comment but the user have to found a way to change their code because I dunno if we have an equivalent

ljharb · 2026-01-27T06:31:29Z

If there's no equivalent, then probably it doesn't make sense to provide a codemod until there is?

AugustinMauroy · 2026-02-01T15:20:41Z

If there's no equivalent, then probably it doesn't make sense to provide a codemod until there is?

IMO we should warn it on readme and people will be aware and then they know that will change how does it work.
cc @JakobJingleheimer what do you think ?

avivkeller · 2026-02-02T22:09:46Z

+		console.warn(
+			`[Codemod] Warning: ${methodName} at ${fileName}:${line}:${column} has no direct equivalent in node:test. Please migrate manually.`,
+		);


cc @nodejs/test_runner a onFailure (perhaps afterFail, keeping the naming similar) handler is a pretty neat feature for us to include.

Also, onFinish -> after, right?, or does after not run on the completion of the test it's created in?

aviv can I invite you to open an issue on test runner repo

Co-Authored-By: Aviv Keller <me@aviv.sh>

Co-Authored-By: Bruno Rodrigues <swe@brunocroh.com>

avivkeller

After rebase LGTM

ljharb · 2026-08-06T05:02:37Z

fwiw i still don't think this is a responsible codemod to exist unless it can cover 100% of the features of the thing it's codemodding away from.

mcollina · 2026-08-06T08:14:46Z

I concur with @ljharb

The reasons why one uses tape are the opposite of why one would use node:test. Both totally valid.

AugustinMauroy · 2026-08-06T15:59:03Z

agree with you. node:test ins't a replacement like tape is dangerous or slow or iDK.
But this is usefull for people who just wanna to have small unit test for their js function. Since it's help you to remove on dep it's also reduce the impact surface.

let's take an example, if you have a small js package that have typescript, tsx, tape as dep. just with one codemod you can remove one dep. and with nodejs/correct-ts-specifiers you maybe able to remove tsx from your dep

So imo we can land this but improve the docs about "Why and when you should use it "

AugustinMauroy added 14 commits December 10, 2025 11:47

feat(tape-to-node-test): first draft

0832a90

fix: use workflow convention

527acf4

fix: use EOL

c5ca0a5

chore: update readme

59cf844

feat(tape-to-node-test): support dynamic import

af14a96

feat(tape-to-node-test): support more cases

f665ea8

fix: code format

08e74b0

feat(tape-to-node-test): support timeout

e51e443

feat(tape-to-node-test): improve

7cd866b

fix: linting/issue

506db48

test,fix: handling of timeout

256c540

Delete index.ts

a6caff6

Merge branch 'main' into tape-to-node-test

15c63ec

remove dep

c0037e1

AugustinMauroy marked this pull request as ready for review December 15, 2025 19:28

AugustinMauroy requested review from a team and ljharb December 15, 2025 19:28

AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Dec 15, 2025

brunocroh reviewed Dec 18, 2025

View reviewed changes

Comment thread recipes/tape-to-node-test/src/workflow.ts Outdated

Comment thread recipes/tape-to-node-test/src/workflow.ts

Comment thread recipes/tape-to-node-test/src/workflow.ts Outdated

Comment thread recipes/tape-to-node-test/src/workflow.ts

AugustinMauroy and others added 2 commits December 18, 2025 22:35

Apply suggestions from code review

5b9ce43

Co-authored-by: Bruno Rodrigues <swe@brunocroh.com>

fix: code style

5e5d232

brunocroh reviewed Jan 6, 2026

View reviewed changes

Comment thread recipes/tape-to-node-test/src/workflow.ts

ljharb reviewed Jan 7, 2026

View reviewed changes

Comment thread recipes/tape-to-node-test/tests/new-features/expected.js

Comment thread recipes/tape-to-node-test/tests/no-callback-args/expected.js Outdated

Comment thread recipes/tape-to-node-test/tests/require-import/expected.js Outdated

brunocroh added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Jan 9, 2026

AugustinMauroy and others added 4 commits January 17, 2026 17:20

Update recipes/tape-to-node-test/src/workflow.ts

8e0e92c

Co-authored-by: Bruno Rodrigues <swe@brunocroh.com>

better async cb handling

630c116

wip

654294a

handle test and plan

ddf833a

AugustinMauroy added 3 commits January 21, 2026 21:00

WIP

a44f92e

improve async/sync handling

fc28208

update

2630241

avivkeller reviewed Feb 2, 2026

View reviewed changes

AugustinMauroy changed the title ~~feat(tape-to-node-test): first draft~~ feat(tape-to-node-test): introduce Mar 20, 2026

AugustinMauroy added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Mar 20, 2026

AugustinMauroy and others added 3 commits April 6, 2026 10:28

apply review

f13199b

Co-Authored-By: Aviv Keller <me@aviv.sh>

better t.pass

39d0797

Co-Authored-By: Aviv Keller <me@aviv.sh>

Update workflow.ts

21a2d7c

AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Apr 9, 2026

brunocroh approved these changes Apr 15, 2026

View reviewed changes

brunocroh self-requested a review April 24, 2026 20:51

brunocroh reviewed Apr 25, 2026

View reviewed changes

Comment thread recipes/tape-to-node-test/src/workflow.ts

Comment thread recipes/tape-to-node-test/tests/test-options/input.js

Comment thread recipes/tape-to-node-test/tests/test-options/expected.js

Comment thread recipes/tape-to-node-test/src/workflow.ts

AugustinMauroy and others added 3 commits April 25, 2026 19:54

apply suggestion

beb9739

Co-Authored-By: Bruno Rodrigues <swe@brunocroh.com>

timeout support

6da0864

add remove line

2769176

brunocroh approved these changes Apr 25, 2026

View reviewed changes

AugustinMauroy added 3 commits April 25, 2026 20:42

Merge branch 'main' into tape-to-node-test

a7c16f4

Update package-lock.json

a12f72e

fix

56a15b4

avivkeller approved these changes Aug 5, 2026

View reviewed changes

Merge branch 'main' into tape-to-node-test

78e33a3

Uh oh!

Uh oh!

Conversation

AugustinMauroy commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issue

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AugustinMauroy commented Jan 17, 2026

Uh oh!

AugustinMauroy commented Jan 21, 2026

Uh oh!

ljharb commented Jan 27, 2026

Uh oh!

AugustinMauroy commented Feb 1, 2026

Uh oh!

Uh oh!

avivkeller Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avivkeller left a comment

Choose a reason for hiding this comment

Uh oh!

ljharb commented Aug 6, 2026

Uh oh!

mcollina commented Aug 6, 2026

Uh oh!

AugustinMauroy commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AugustinMauroy commented Dec 10, 2025 •

edited

Loading

AugustinMauroy commented Aug 6, 2026 •

edited

Loading