Repository navigation
fix(dockerize): do not write the entrypoint on --dry-run - #30
Merged
Merged
Conversation
The entrypoint script was written unconditionally after synchronization, so `pdm dockerize --dry-run` failed with FileNotFoundError because the target directory is never created in dry-run mode. The script is now generated and printed to stdout instead, leaving the filesystem untouched.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 93.99% 94.06% +0.06%
==========================================
Files 6 6
Lines 433 438 +5
Branches 60 61 +1
==========================================
+ Hits 407 412 +5
Misses 22 22
Partials 4 4 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdm dockerize --dry-runalways failed withFileNotFoundErrorondist/docker/entrypoint: the entrypoint was written unconditionally after synchronization, while neither synchronizer creates the target directory in dry-run mode.The entrypoint script is now printed to stdout instead of being written, so
--dry-rungives a complete preview (packages and entrypoint) without touching the filesystem. Covered by new command-level tests for both the pip and uv paths.