Skip to content

Comments

Update and rename OpenRails_by_wmuzeke.xml to Open Rails.xml#376

Open
wmuzeke wants to merge 1 commit intonotepad-plus-plus:masterfrom
wmuzeke:patch-2
Open

Update and rename OpenRails_by_wmuzeke.xml to Open Rails.xml#376
wmuzeke wants to merge 1 commit intonotepad-plus-plus:masterfrom
wmuzeke:patch-2

Conversation

@wmuzeke
Copy link
Contributor

@wmuzeke wmuzeke commented Feb 19, 2026

Updated the file name to match the JSON information.

@pryrt pryrt added the needs improvement will be rejected if requested improvement isn't made label Feb 19, 2026
@pryrt
Copy link
Contributor

pryrt commented Feb 19, 2026

Currently, the JSON and the filename do all match. It's only with your piecewise flock of PRs that there was ever any mismatch.

Please do all the changes you want, and make one PR. Your other three PR have been rejected, because piece-by-piece, none of them pass the checkers. You can just edit the file in the patch-2 branch to continue with this PR (or, if you are doing everything from the PR itself, just go to the "Files Changed" section, and edit the file from there in the website).

Second, the idea behind this PR is flawed: the name Open Rails.xml does not match the rules in CONTRIBUTING.md:

requirement: The XML file must be given a unique name, because of the file structure. The name must include the name of the language, but also something else to make it unique.

Note the "but also something else". That's why I added the author to the filename when I incorprotated your original submission, like is recommended in the CONTRIBUTING.md.

Secondly, under that same requirement description, it says:

Use underscores or hyphens or periods to separate words, not spaces.

You used spaces in the original PR, which violates that rule. That's why I removed the space from the filename when I incorporated your original submission.

So a PR that changes the filename (and associated JSON) from OpenRails_by_wmuzeke.xml to Open Rails.xml will be rejected out-of-hand for violating two pieces of the UDL file naming requirements. And piecewise PR that don't fully pass the automated checks will be rejected as well.

Please follow the rules and conventions set forth in CONTRIBUTING, or your submissions will continue to be rejected.

@wmuzeke
Copy link
Contributor Author

wmuzeke commented Feb 19, 2026

Thanks for the explanation. I am new to using Github so I'm still learning how it works. I didn't realize you could do multiple changes on one pull request. I wasn't sure whether it was the JSON or the file name that needed updating to match. I now see the requirement that no spaces are allowed in the file name. Regards, David.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs improvement will be rejected if requested improvement isn't made

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants