Fix assertion order#834
Closed
mendral-app[bot] wants to merge 1 commit into
Closed
Conversation
The test asserts the URL starts with https://console.notte.cc, but the console link opens in a new tab. Previously, aobserve() was called before switch_tab, so the observation captured the original tab's URL, causing flaky failures. Reorder to switch tabs first, then observe and assert.
|
PR author is not in the allowed authors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
switch_tabbeforeaobserve()intest_observe_with_instructionsso the observation captures the new tab's URL (console.notte.cc) instead of the original tab's URL (www.notte.cc)Fixes flaky test caused by asserting the URL on the wrong tab. The console link opens in a new tab, so we need to switch tabs before observing.
Related insight: https://app.mendral.com/insights/01KRYW70WKW0ZX0NV98DH6KEA0
Note
Created by Mendral. Tag @mendral-app with feedback or questions.