Skip to content

fix: minVersion returns the true minimum for > in includePrerelease mode #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spokodev wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

fix: minVersion returns the true minimum for > in includePrerelease mode #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ranges/min-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ const minVersion = (range, loose) => {
case '>':
if (compver.prerelease.length === 0) {
compver.patch++
// in includePrerelease mode the next patch's lowest prerelease
// (e.g. 1.0.1-0) also satisfies `>1.0.0` and is lower than 1.0.1,
// so it is the true minimum -- matching the prerelease `>` case below
if (range.includePrerelease) {
compver.prerelease.push(0)
}
} else {
compver.prerelease.push(0)
}
Expand Down
5 changes: 5 additions & 0 deletions test/ranges/min-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ test('minimum version in range tests', (t) => {
['>2 || >1.0.0-0', '1.0.0-0.0'],
['>2 || >1.0.0-beta', '1.0.0-beta.0'],

// includePrerelease: the lowest prerelease of the next version is the true
// minimum for a `>` bound (and lower than the plain next version)
['>1.0.0', '1.0.1-0', { includePrerelease: true }],
['>2 || >1.0.0', '1.0.1-0', { includePrerelease: true }],

// Impossible range
['>4 <3', null],
].forEach((tuple) => {
Expand Down