-
Notifications
You must be signed in to change notification settings - Fork 3
"Collections and Granules" page with some "Glossary" things #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
"Collections and Granules" page with some "Glossary" things #34
Conversation
…ordered glossary.
|
Also, I was curious about the auto checks failed error... my limited research suggested that a repo admin may need to adjust the workflow permissions (I guess for me) or it has something to do with the PR not coming from a branch within the main repository (aka, my fork). |
|
I am not sure about removing stubs (sidebar headings with no content). This was done so that we have a structure to build out. Removing them seems like a backwards step. I suggest we keep these lines in the An alternative would be to keep the headings and have a page with "Work in Progress" |
|
Looking at the details, the failing check appears to be because a url link does not exist. That might need some trouble shooting. |
|
@andypbarrett thanks for looking so fast! I'm not sure why I didn't think to just comment out the unused sidebar headers... I can put those back in hidden. Regarding the glossary.qmd: I actually did try to figure out a way to script this and ended up getting frustrated / limited by my python-ing haha. I can definitely tinker with it more, but for the short term, and while our glossary is short, I did like the idea of still having something of a glossary in our appendix... I do think a script will be better for the long term, but until I/ you/ someone figures out the best way to do it, I am okay maintaining this static version when the glossary.yml gets updated. If you hate this short term idea, or others do, it can obviously be ditched. Are you okay with the collections-granules.qmd? I wasn't sure how deep to go, but thought this was an okay start. |
andypbarrett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've identified some sections that need clarification or don't quite nail the concept. I've also made some suggestions for additions and changes.
I don't think we will get to scripting the glossary for a while so what you have for the glossary page works for now.
Co-authored-by: Andy Barrett <[email protected]>
|
@andypbarrett and anyone else following along: |
|
My only comment so far is regarding this definition: |
|
@mikala-nsidc just made a new commit that modifies this language to be less specific! |
|
@saberbrasher Thanks!! Looks good! |
I created the page for "Collections and Granules". I also created a .qmd file for a "Glossary" page (and added it to the Appendices) that comes with a search bar and drop-downs. Still more to do on filling out the glossary (and perhaps making it better / more sophisticated in the future), adding in the extension features (so clicking on the phrase and getting the definition), but figured it was worth it to go ahead and push up the "Collections and Granules" page in the meantime. I also alphabetized the .yml version of the glossary.
I also removed some sidebar headers that we currently have no page/ content for... they can always be added back later, but figured it better to take them away for now as they are not clickable.Take a look, please! :-)