object: Drop meta headers from PUT chunk requests - #408
Open
cthulhu-rider wants to merge 1 commit into
Open
Conversation
Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
object-put-chunk-meta-header
branch
from
August 9, 2026 07:54
8b8605c to
3038602
Compare
roman-khimov
previously requested changes
Aug 9, 2026
roman-khimov
left a comment
roman-khimov
left a comment
Member
There was a problem hiding this comment.
We can't verify data otherwise. And it's not the biggest problem of PUTs.
Contributor
Author
data is verified via verification header |
Member
|
OK, got your point. Repeating meta doesn't make sense, that's true (changing it is also nonsense). So we can do this safely. |
Member
|
Thinking about it a bit more I find meta useful for replay attack protection. We currently don't have it, but we should. And the way it should work for chunks is to bind them to a particular stream which can be done using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.