Restore EC objects during policer relocation - #4119
Open
End-rey wants to merge 1 commit into
Open
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
August 7, 2026 10:14
End-rey
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4119 +/- ##
==========================================
+ Coverage 27.19% 27.30% +0.11%
==========================================
Files 677 677
Lines 46206 46369 +163
==========================================
+ Hits 12564 12661 +97
- Misses 32442 32494 +52
- Partials 1200 1214 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
End-rey
force-pushed
the
policer-object-availability
branch
2 times, most recently
from
August 10, 2026 16:00
2e836cc to
6a7846d
Compare
Fallback to any EC part from each node when exact placement lookup fails. Refs #4019. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
| if s.neoFSNet.IsLocalNodePublicKey(sortedNodes[nodeIdx].PublicKey()) { | ||
| hdr, rc, err = s.localObjects.GetECPart(ctx, cnr, parent, iec.PartInfo{RuleIndex: ruleIdx, Index: nodeIdx}, true) | ||
| } else { | ||
| hdr, rc, err = s.getAnyECPartFromNode(ctx, cnr, parent, ruleIdx, sortedNodes[nodeIdx]) |
| s.log.Info("failed to restore EC object using exact part placement, trying any part per node", | ||
| zap.Stringer("container", cnr), zap.Stringer("object", parent), zap.Stringer("rule", rule), zap.Int("ruleIdx", ruleIdx), zap.Error(err)) | ||
|
|
||
| return s.restoreFromAnyECPartsByRule(ctx, cnr, parent, rule, ruleIdx, sortedNodes, partial) |
Member
There was a problem hiding this comment.
I hope we can deduplicate these strategies in future, non-indexed one is more reliable in general, indexed one can't solve the case of part moving from node B to node A (with complete deletion on B so that garbage marks won't help) while object getter moves from A to B. But this requires more performance tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4019.