Skip to content

sn/object: Fix out-of-range panic in GET/HEAD/RANGE handlers #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roman-khimov merged 1 commit into from
Aug 7, 2026
+3 −2
Merged

sn/object: Fix out-of-range panic in GET/HEAD/RANGE handlers #4120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Changelog for NeoFS Node
### Added

### Fixed
- SN could panic on forwarding GET/HEAD/RANGE request (#4120)

### Changed
- SNs exchange TLS certificates on inter-node connections (#4097)
Expand Down
4 changes: 2 additions & 2 deletions pkg/services/object/get/forward.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func (s *Service) forwardRequest(ctx context.Context, repRules []uint, ecRules [
// try reserve REP holders
for i := range repRules {
// shuffling does not make sense anymore
for nodeIdx := repRules[i]; nodeIdx <= uint(len(sortedNodeLists[i])); nodeIdx++ {
for nodeIdx := repRules[i]; nodeIdx < uint(len(sortedNodeLists[i])); nodeIdx++ {
if fin, err := s.forwardRequestToNode(ctx, sortedNodeLists[i][nodeIdx], op, forwardRequestFn); fin {
return err
}
Expand All @@ -61,7 +61,7 @@ func (s *Service) forwardRequest(ctx context.Context, repRules []uint, ecRules [
}

for i := range ecRules {
for nodeIdx := int(ecRules[i].DataPartNum + ecRules[i].ParityPartNum); nodeIdx <= len(sortedNodeLists[i]); nodeIdx++ {
for nodeIdx := int(ecRules[i].DataPartNum + ecRules[i].ParityPartNum); nodeIdx < len(sortedNodeLists[i]); nodeIdx++ {
if fin, err := s.forwardRequestToNode(ctx, sortedNodeLists[i][nodeIdx], op, forwardRequestFn); fin {
return err
}
Expand Down
Loading