env: enable tls on some nodes - #1405
Merged
Merged
Conversation
evgeniiz321
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
July 20, 2026 18:13
evgeniiz321
marked this pull request as draft
July 20, 2026 18:13
evgeniiz321
marked this pull request as ready for review
July 22, 2026 17:56
roman-khimov
left a comment
roman-khimov
left a comment
Member
There was a problem hiding this comment.
I'm mostly interested in:
- node functioning and registering its TLS port correctly in netmap
- other nodes connecting to TLSed one (object on TLS node, GET via open)
- TLSed node connecting to regular ones (object on open node, GET via TLS)
- gateways connecting to TLSed node and doing the same accesses thing
- registering TLS port in netmap and running with two really open ports, unregistered one being non-TLS, everything should work when going through any of these ports
| @@ -0,0 +1,28 @@ | |||
| -----BEGIN PRIVATE KEY----- | |||
Member
There was a problem hiding this comment.
Static key won't work for SN since nspcc-dev/neofs-node#4095, you need to extract the key from wallet with NeoGo (@532910 does this in production).
evgeniiz321
force-pushed
the
ezayats/tls
branch
3 times, most recently
from
July 27, 2026 15:31
0fbfc24 to
b92a925
Compare
evgeniiz321
marked this pull request as draft
July 27, 2026 15:32
evgeniiz321
force-pushed
the
ezayats/tls
branch
6 times, most recently
from
July 28, 2026 22:06
266a143 to
1bfd4bf
Compare
Contributor
Author
Added missing tests + enabled TLS for the most commonly used fixture throughout the tests. |
evgeniiz321
marked this pull request as ready for review
July 28, 2026 22:10
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
roman-khimov
approved these changes
Aug 6, 2026
| [ | ||
| x509.DNSName(self.domain), | ||
| x509.DNSName(f"*.{self.domain}"), | ||
| x509.IPAddress(ipaddress.ip_address("127.0.0.1")), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.