Repository navigation
feat: Allow configuration for resources and SecurityContext for all containers and pods - #63
Conversation
7b900ac to
89c8f0c
Compare
89c8f0c to
412d5bf
Compare
412d5bf to
5381644
Compare
|
The CI seems to be failing, could you take a look? |
5381644 to
cc01a5c
Compare
I did see I had a security context for it where there wasn't one before. Removed so possibly will actually be functionally identical to how it was before. I'll try to test on a more bare bones setup when I get home tonight - all our clusters in office do some auto injection of basic securityContext stuff which actually causes other breakages if I don't explicitly set the full thing. Very awkward but also why this was something we needed to be able to expose. |
a42dc9a to
dd07d89
Compare
| name: numaflow | ||
| type: application | ||
| version: 0.5.5 | ||
| version: 0.5.6 |
There was a problem hiding this comment.
This was re-updated now so hopefully linting is good. Got reverted as I tried to verify no functional changes last night.
vaibhavtiwari33
left a comment
vaibhavtiwari33
left a comment
There was a problem hiding this comment.
nit: Could we also update the readme (charts/numaflow/README.md) with the new values?
| name: numaflow | ||
| type: application | ||
| version: 0.5.5 | ||
| version: 0.5.6 |
There was a problem hiding this comment.
Would need to be changed to 0.5.7
There was a problem hiding this comment.
Oh! I see, will do. Should tlhe front-page readme be updated as well with the helm listing? I'm not clear if it auto updates but looking at current I'm guessing it does not?
…ontainers and pods. Also allow for customizing pod and service names with templating Signed-off-by: Matt Warner <matthew.d.warner@lmco.com>
…-resources-and-sc
dd07d89 to
0db3088
Compare
Update made, seemed to fit with current style of simple availabilty and example, but let me know if you think something different is needed |
3 participants
Closes #62
This allows setting
resourcesandsecurityContextfor all containers and pods. This allows for explicit compliance with ResourceQuotas and Pod Security Admission rules without requiring other mutating webhook to add these. The default behavior and settings should be preserved.Additionally, because it's something that's helped us with some internal naming in multi-use namespaces, I added ability to also customize service and deployment names with
tplsupport (so I can use stuff like.Release.Name) . Again, default names are all preserved.Dev note: Since i'm not bumping a numaflow version, I wasn't sure how well to follow the Maintainers steps as the
sync-mirrored-filesdoesn't work for v1.8.4->v1.8.4. So I'm unclear if there's some quirk that this might break in the automation process if there are assumptions it has about diffs.