Copyedit and fix textual and formatting errors in SDG form #9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,71 +1,69 @@ | ||
| --- | ||
| name: New SDG proposal | ||
| description: >- | ||
| Provide the required information for a new Small Development Grant proposal. | ||
| labels: | ||
| - Awaiting approval | ||
| body: | ||
| - id: instructions | ||
| type: markdown | ||
| attributes: | ||
| value: | | ||
| Complete the below fields to submit a Small Development Grant proposal. | ||
| Note that a project lead has to approve the proposal submission. | ||
|
Comment on lines
+12
to
+13
Member
Author
There was a problem hiding this comment. Use clearer and more appropriate wording |
||
| > [!IMPORTANT] | ||
|
Member
Author
There was a problem hiding this comment. Use a more appropriate and less negative admonition type here |
||
| > This form is only for NumFOCUS [sponsored](https://numfocus.org/sponsored-projects) and [affiliated](https://numfocus.org/sponsored-projects/affiliated-projects) projects. | ||
| > Discuss the proposal with the project leads before submitting this issue. | ||
| > Each project has a limit of one proposal per round. | ||
| - id: project | ||
| type: input | ||
| attributes: | ||
| label: Project | ||
| description: "Which NumFOCUS project is this proposal for (comma separate the names if a collaboration between multiple projects)" | ||
|
There was a problem hiding this comment. Was removing the question mark intentional? |
||
| validations: | ||
| required: true | ||
| - id: summary | ||
| type: input | ||
| attributes: | ||
| label: Summary | ||
| description: "Two-sentence summary of the proposal" | ||
| validations: | ||
| required: true | ||
| - id: submitter | ||
| type: input | ||
| attributes: | ||
| label: Submitter | ||
| description: "Who is submitting this request" | ||
| placeholder: "Full name" | ||
|
Member
Author
There was a problem hiding this comment. Avoid embedding the assumption that the ordering or structure of the submitter's name conforms to Western cultural norms |
||
| validations: | ||
| required: true | ||
| - id: lead | ||
| type: input | ||
| attributes: | ||
| label: Project lead | ||
| description: "Who is the project lead that can approve this proposal (GitHub username)" | ||
| placeholder: "@github_username" | ||
| validations: | ||
| required: true | ||
| - id: impact | ||
| type: textarea | ||
| attributes: | ||
| label: Community benefit | ||
| description: "How will this proposal positively impact the community" | ||
|
Member
Author
There was a problem hiding this comment. Simplified and clarified this phrasing to be more direct and less awkward/unidiomatic. Also fixed a typo. |
||
| validations: | ||
| required: true | ||
| - id: amount | ||
| type: input | ||
| attributes: | ||
| label: Amount requested | ||
| description: "How much money is required to execute this proposal (max $10k)" | ||
|
Member
Author
There was a problem hiding this comment. May as well be explict about the limit |
||
| placeholder: "1000" | ||
| validations: | ||
| required: true | ||
| - id: plan | ||
| type: textarea | ||
| attributes: | ||
| label: Execution plan | ||
| description: "Who will implement this, what's the timeline, and how will it be carried out" | ||
|
Comment on lines
-68
to
+67
Member
Author
There was a problem hiding this comment. Fixes the spurious quotes in the block scalar here being unintentionally displayed in the output |
||
| validations: | ||
| required: true | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No obvious need to specify not normalizing trailing newlines (of which there is only the one anyway)