Conversation
spawnia
left a comment
There was a problem hiding this comment.
Good change, I am all for making this switch in the next major version.
|
I did some regex replacements for the |
# Conflicts: # src/Pagination/PaginationArgs.php # src/Schema/Directives/AggregateDirective.php
|
I cleaned up a couple of remaining places where the interface could be used and added another change on top. It is somewhat unrelated but touches the same parts of the code and is also breaking, so I figured we might as well save ourselves the trouble of resolving merge conflicts and add it in one go. |
# Conflicts: # CHANGELOG.md # src/WhereConditions/WhereConditionsHandler.php
|
i think this pr is fine, i don't understand why my change would make codecov care all of a sudden. |
No worries, we can just ignore that.
Merge to |
In laravel 9, a new interface
Illuminate\Contracts\Database\Query\Builderwas added to improve the readability of typehints likeIlluminate\Database\Query\Builder|Illuminate\Database\Eloquent\Builder|Illuminate\Database\Eloquent\Relations\Relation.This pr is just some refactoring to use that interface and I also found some duplicate code which i moved to a trait.
(Breaking) Changes
When building custom directives, people now need to use the new Builder interface to typehint. So this would be something for a v7.