Only allow deletion of related models in nested mutations#2454
Draft
lucaslenz wants to merge 16 commits intonuwave:masterfrom
Draft
Only allow deletion of related models in nested mutations#2454lucaslenz wants to merge 16 commits intonuwave:masterfrom
lucaslenz wants to merge 16 commits intonuwave:masterfrom
Conversation
lucaslenz
changed the title
Collaborator
|
Please resolve conflicts. |
spawnia
requested changes
Oct 6, 2023
tests/Integration/Execution/MutationExecutor/BelongsToManyTest.php
Outdated
Show resolved
Hide resolved
tests/Integration/Execution/MutationExecutor/BelongsToManyTest.php
Outdated
Show resolved
Hide resolved
Collaborator
|
Again, your branch is out of date. You need to add this repository as a remote to your project and merge/rebase against the latest |
…/lighthouse into nestdMutationDeleteBug # Conflicts: # tests/Integration/Execution/MutationExecutor/BelongsToManyTest.php # tests/Integration/Execution/MutationExecutor/HasManyTest.php # tests/Integration/Execution/MutationExecutor/MorphManyTest.php
…tdMutationDeleteBug
Collaborator
|
The merge was totally messed up, I just fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2455
Changes
Add failing test cases for a bug concerning the delete field in nested mutations. Documentation says:
delete the related model and the association to it(link).These failing test cases show that actually any object can be deleted no matter of the relationship status to the root object.
This should not be possible!
Breaking changes
I am not aware of any breaking changes.