Skip to content

Conversation

@LastDragon-ru
Copy link
Contributor

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

Docs about @searchBy and @sortBy directives 😀 (#1782)

Breaking changes

Nope.

Copy link
Collaborator

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality looks great and the critique of the Lighthouse implementation is valid. However, I would like to keep our docs more targeted towards how things are done in Lighthouse - without the need to get into nuanced discussions about directive designs, dependencies and more. I left a suggestion at #1782 (comment) for a lightweight reference to your package.

@LastDragon-ru LastDragon-ru force-pushed the strictly-typed-searching-and-sorting branch from fbbe840 to 1f02a2a Compare January 25, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants