Conversation
e340e55 to
41d75fe
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdded Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@BobbieGoede do you know why we replace one set of h3 exports with another? |
I'm not sure which exports/replacements you mean exactly, /cc @kazupon |
|
@danielroe It re-exports all utilities from The re-export from I can understand this could cause the duplication issue you're seeing when both packages are resolved separately. |
|
@danielroe is this PR still relevant to fix the issue you ran into? |
|
i'm not sure - ecosystem ci is blocked by the ts-expect-error that my other pr removes - i'll check again after that merges |
|
nope! we are good now |
🔗 Linked issue
📚 Description
otherwise we can end up with different versions of
@intlify/utils/h3and@intlify/h3https://github.com/nuxt/ecosystem-ci/actions/runs/23833781405/job/69473060451
Summary by CodeRabbit