Skip to content

fix: cross-device link when drive letter is same - #1312

Closed
Agritite wants to merge 1 commit into
nvm-windows:masterfrom
Agritite:master
Closed

fix: cross-device link when drive letter is same#1312
Agritite wants to merge 1 commit into
nvm-windows:masterfrom
Agritite:master

Conversation

@Agritite

@Agritite Agritite commented Nov 27, 2025

Copy link
Copy Markdown

fixes #1311

@Agritite Agritite changed the title fix: cross-link device when drive letter is same fix: cross-device link when drive letter is same Nov 27, 2025
@Desktop1230

Desktop1230 commented Dec 1, 2025

Copy link
Copy Markdown

i need help to build up my respon

@github-actions

github-actions Bot commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions Bot added the Stale Stale label Jan 2, 2026
@Agritite

Agritite commented Jan 2, 2026

Copy link
Copy Markdown
Author

no

@github-actions github-actions Bot removed the Stale Stale label Jan 4, 2026
@Agritite Agritite mentioned this pull request Jan 28, 2026
Closed
@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions Bot added the Stale Stale label Feb 3, 2026
@Agritite

Agritite commented Feb 3, 2026

Copy link
Copy Markdown
Author

false

@github-actions github-actions Bot removed the Stale Stale label Feb 5, 2026
@github-actions

github-actions Bot commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions Bot added the Stale Stale label Mar 8, 2026
@Agritite

Agritite commented Mar 11, 2026

Copy link
Copy Markdown
Author

not really

@github-actions github-actions Bot removed the Stale Stale label Mar 12, 2026
@github-actions

github-actions Bot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions Bot added the Stale Stale label Apr 11, 2026
@Agritite

Agritite commented Apr 13, 2026

Copy link
Copy Markdown
Author

bump

@github-actions github-actions Bot removed the Stale Stale label Apr 15, 2026
@github-actions

github-actions Bot commented May 16, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions Bot added the Stale Stale label May 16, 2026
@Agritite

Agritite commented May 18, 2026

Copy link
Copy Markdown
Author

bump

@github-actions github-actions Bot removed the Stale Stale label May 20, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions Bot added the Stale Stale label Jun 19, 2026
@Agritite

Agritite commented Aug 12, 2026

Copy link
Copy Markdown
Author

not stale

@github-actions github-actions Bot removed the Stale Stale label Aug 14, 2026
@coreybutler

coreybutler commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

I appreciate the contribution.

We will not be releasing anything further on the 1.x.x line. Version 2 is a complete rewrite and this PR is no longer relevant to the new code base.

Cross-device links are supported in v2. Shim mode is the easiest, but it's possible in the legacy link mode too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Issue]: comparing drive letters is not enough to fix #1206

3 participants

@Agritite @Desktop1230 @coreybutler