Open
Conversation
823d520 to
6ca17ea
Compare
d320a7b to
b60ad51
Compare
731fee5 to
0d7f0fb
Compare
15c7eff to
76deb45
Compare
3682723 to
985af54
Compare
3682723 to
0b13b2d
Compare
rogerwang
pushed a commit
that referenced
this pull request
Sep 7, 2016
This CL whitelists the Service NSW Kiosk Utility for use in Public Sessions. TEST=None BUG=626850 Review-Url: https://codereview.chromium.org/2287493002 Cr-Commit-Position: refs/heads/master@{#414992} (cherry picked from commit a7b0d01) Review URL: https://codereview.chromium.org/2292063002 . Cr-Commit-Position: refs/branch-heads/2840@{#35} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}
5d09f04 to
8e30c84
Compare
cb6fc05 to
151b8e5
Compare
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
BUG=663041 Review-Url: https://codereview.chromium.org/2514733004 Cr-Commit-Position: refs/heads/master@{#433440} (cherry picked from commit 662a14a) Review URL: https://codereview.chromium.org/2521063002 . Cr-Commit-Position: refs/branch-heads/2924@{#35} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
This patch fixes areas where NetworkRequest.url conversion was missed because file lacked doctype. R=dgozman,luoe BUG=680054 NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2627073003 Cr-Commit-Position: refs/heads/master@{#444962} (cherry picked from commit 5b07860) Review-Url: https://codereview.chromium.org/2645403006 Cr-Commit-Position: refs/branch-heads/2987@{#35} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
… taken This CL introduces a member variable |mPreviewParameters| to cache the preview capture parameters in order to restore them after a picture is being taken and, more importantly (see bug), delays restoring those parameters until after the picture is actually taken. While debugging these changes with a Nexus 7 and a Galaxy Note 2 7100, I reckoned that the Nexus 7 is very delicate so I added some try-catches and avoided setting the picture resolution if not truly set by the user (== use preview size). BUG=706674 Review-Url: https://codereview.chromium.org/2826453002 Cr-Commit-Position: refs/heads/master@{#465118} (cherry picked from commit a6c1b9d) Review-Url: https://codereview.chromium.org/2821343002 . Cr-Commit-Position: refs/branch-heads/3071@{#35} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
…rchbox changes: disable the hover state when fullscreen app list is enabled for mic/close icons. (cherry picked from commit 591f32d) TBR: stevenjb@chromium.org Test: emulator test Bug: 748561 Change-Id: Ibbe00c47e9d071ebf53d74401f817b8c67509123 Reviewed-on: https://chromium-review.googlesource.com/585449 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489397} Reviewed-on: https://chromium-review.googlesource.com/585601 Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#35} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
Exit the mode once the selection is done. TBR=kaznacheev@google.com (cherry picked from commit 1784cc4) Bug: 761041 Change-Id: I334d38ca4e77c377ae5657c2ff18080c43670824 Reviewed-on: https://chromium-review.googlesource.com/646597 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499306} Reviewed-on: https://chromium-review.googlesource.com/651726 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#35} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
This patch ensures that the legacy touch calibration data is stored in the legacy format. This is to ensure that if anything breaks with the new changes, we have something to fallback on. Component: display preferences, touch Bug: 599985 Change-Id: I77c6fd22634ae447c5829565b912a5142b0eb16d Reviewed-on: https://chromium-review.googlesource.com/720161 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509211}(cherry picked from commit 98a0372) Reviewed-on: https://chromium-review.googlesource.com/723672 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#35} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
[omnibox navigation] Allow incognito switching for singletons We tried aligning the behaviors of disposition (old) SINGLETON_TAB and (new) SWITCH_TO_TAB. But the former supports e.g. opening chrome://settings from incognito mode, which requires searching across anonymity boundaries (if we don't want to open a duplicate). This change allows the former disposition to search across anonymity levels. TBR=krb@chromium.org (cherry picked from commit bc51d22) Bug: 801494 Change-Id: I37d96e1de6f5f7c997858ac296a2756ae69769da Reviewed-on: https://chromium-review.googlesource.com/867932 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531098} Reviewed-on: https://chromium-review.googlesource.com/881823 Reviewed-by: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#35} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
Media Engagement is recording data on all platforms but only desktop should use it to bypass autoplay. Bug: 818377 Change-Id: I8dc0923986bd13b75b80c7e02b7e735d549935db Reviewed-on: https://chromium-review.googlesource.com/949142 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540882}(cherry picked from commit 0cf32f7) Reviewed-on: https://chromium-review.googlesource.com/951767 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#35} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
…dAccountFeature flag . Bug: 832919, 831251 Change-Id: I113dbedec6ee9b79f109aff876a2ccc97e057b73 Reviewed-on: https://chromium-review.googlesource.com/1014283 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551149}(cherry picked from commit 475b4f6) Reviewed-on: https://chromium-review.googlesource.com/1012940 Cr-Commit-Position: refs/branch-heads/3396@{#35} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
https://chromium.googlesource.com/catapult.git/+log/c02f8a85059d..0e97383613e5 $ git log c02f8a850..0e9738361 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 wangxianzhu [Tracing] Remove unused resize_sensor.html and css-element-queries Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com, sullivan@chromium.org (cherry picked from commit d7792e6) Change-Id: I0b40463945f848bec8bd0677cd054a2400191428 Reviewed-on: https://chromium-review.googlesource.com/1072960 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/master@{#561751} Bug: 842238 Reviewed-on: https://chromium-review.googlesource.com/1077086 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#35} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
Originally the webview content was always set to clickable but after http://crrev.com/551479 it wasn't. This CL restores original behaviour. Also adds a test to ensure this remains true in the future. TBR=laisminchillo@chromium.org (cherry picked from commit 26f4a8e) Bug: 857427 Change-Id: If7a765f146290b933f57e514f26ad8a672f7695e Reviewed-on: https://chromium-review.googlesource.com/1127951 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577138} Reviewed-on: https://chromium-review.googlesource.com/1148383 Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#35} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
This reverts commit 6493250. Reason for revert: Breaks when opening devtools on debug build. Original change's description: > Reland "Convert tcp_device_provider.cc to mojo host resolver" > > This is a reland of ac880b3 > > Switched to using > ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which > outlives TCPDeviceProvider. The original was reverted because of a > crash when TCPDeviceProvider tried to access a destroyed > BrowserContext, see http://crbug.com/879060. > > Original change's description: > > Convert tcp_device_provider.cc to mojo host resolver > > > > Bug: 874653 > > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd > > Reviewed-on: https://chromium-review.googlesource.com/1185626 > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#586738} > > Bug: 874653 > Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24 > Reviewed-on: https://chromium-review.googlesource.com/1197265 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587750} TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org Change-Id: Iaf8ef85f3696e6fc290b505edeb7989a99adab29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874653 Reviewed-on: https://chromium-review.googlesource.com/1199709 Reviewed-by: Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588075}(cherry picked from commit 5366af8) Reviewed-on: https://chromium-review.googlesource.com/1205490 Cr-Commit-Position: refs/branch-heads/3538@{#35} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
libtegrav4l2.so's implementation of V4L2_G_FMT has a bug which will make it return 0 planes for single-plane multiplanar formats. We obviously cannot have a multiplanar format with 0 planes, so add a workaround at the fake-ioctl level. Implement it as a case-switch for future-proofing against other workarounds we will likely have to add. Also add a few recommendations in v4l2_device.cc against the temptation to spare some memory by using an appropriately-sized array of v4l2_planes: it turns out libv4l2 also likes to write above the number of passed planes, and using anything shorter than VIDEO_MAX_PLANES will result in memory corruption DCHECKS being raised. BUG=893661 TEST=Checked that VDA unittest was passing on both hana and nyan_big. Change-Id: I7ea638f19f5bf0bdfaa0a47885577eb9dec4c225 Reviewed-on: https://chromium-review.googlesource.com/c/1275727 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by: Kuang-che Wu <kcwu@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599135}(cherry picked from commit 029544d) Reviewed-on: https://chromium-review.googlesource.com/c/1282087 Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#35} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
Article thumbnails are now fetched for suggestions from feed. We fetch with the cached image fetcher, which is shared with feed. Bug: 841522 Change-Id: I283fa2ea145341fb28dd337026a57abbd36aec77 Reviewed-on: https://chromium-review.googlesource.com/c/1344549 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612814}(cherry picked from commit 1a157ed) Reviewed-on: https://chromium-review.googlesource.com/c/1361590 Reviewed-by: Dan H <harringtond@google.com> Cr-Commit-Position: refs/branch-heads/3626@{#35} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
This is for consistency with Windows and allows minimized windows to be activated. BUG=924075 R=sky,fbeaufort Change-Id: Ic86ffba47805b2ba4f5c8f049cdccd2e75be8d9b Reviewed-on: https://chromium-review.googlesource.com/c/1437263 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626192}(cherry picked from commit 28e7da0) Reviewed-on: https://chromium-review.googlesource.com/c/1442238 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3683@{#35} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
…ers" This reverts commit 49f30ad. Reason for revert: Still breaking iOS specific features. Original change's description: > Reland: OOR-CORS: Introduce ResourceRequest::cors_exempt_headers > > Changes from the original patchset: > - variation header support for iOS Chrome > - additional variation header support for Chromecast > - additional variation header support for StoragePartition > > Original descriptions: > > Now ResourceRequest has multiple special header entries that are aimed > > for escaping from CORS checks for internal uses. This patch introduces > > cors_exempt_headers to handle this kind of entries in an unified way. > > > > Also this patch removes {Get|Set}ClientDataHeader interfaces from > > WebURLRequest because these should not be used in Blink. > > > Bug: 870173 > > Change-Id: I5ae5a4a58df30e54064da5b7ab74abb69c9e42a7 > > Reviewed-on: https://chromium-review.googlesource.com/c/1445178 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#630268} > > Bug: 931190, 870173 > Change-Id: I0220918d3aa18787d2ed1ef8029f8c568d8afb4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485560 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637641} TBR=kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,eugenebut@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 931190, 870173, 940331 Change-Id: Ide19655bca7a7fb14aa28ca52c3b9ee0f1026fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514290 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#639419}(cherry picked from commit 5f1b4f7a561db065d09d60cb612f1dd157dbd04e) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517498 Cr-Commit-Position: refs/branch-heads/3729@{#35} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.