create new `SiteInstance` when using `new_instance` by ghostoy · Pull Request #37 · nwjs/chromium.src

ghostoy · 2016-08-05T07:55:16Z

There are two types of requests: interactive (e.g. a fetch when NTP is opened) and noninteractive (e.g. a background prefetch). The noninteractive requests are less important and thus they can be dropped first if needed. This CL adds request type to the request. BUG=638224 Review-Url: https://codereview.chromium.org/2271283002 Cr-Commit-Position: refs/heads/master@{#414672} (cherry picked from commit 2a444eb) Review URL: https://codereview.chromium.org/2292963002 . Cr-Commit-Position: refs/branch-heads/2840@{#37} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

ghostoy · 2016-11-08T07:35:44Z

@rogerwang Do I need to update the PR for nw18?

Enables tracking of audio only "watch time" histograms. They are the same as the audio+video ones except there is no requirement on visibility or video size for recording watch time. BUG=633743 TEST=new audio only unittests. Review-Url: https://codereview.chromium.org/2498113004 Cr-Commit-Position: refs/heads/master@{#433102} (cherry picked from commit 051d5b8) Review URL: https://codereview.chromium.org/2517313002 . Cr-Commit-Position: refs/branch-heads/2924@{#37} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

> Bail in RestartToApplyPerSessionFlagsIfNeed when running in kiosk > sessions to allow startup flags be applied. > > BUG=684015 > > Review-Url: https://codereview.chromium.org/2649903004 > Cr-Commit-Position: refs/heads/master@{#445483} > (cherry picked from commit 7c4265c) Review-Url: https://codereview.chromium.org/2654503003 . Cr-Commit-Position: refs/branch-heads/2987@{#37} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

When returning a Window reference to JS, Blink calls ToV8() to convert the C++ DOMWindow pointer to an associated JS DOM wrapper, which ensures the associated WindowProxy is initialized. During a navigation that requires switching DOMWindows, the WindowProxy is detached from the old DOMWindow by calling setDOMWindow() and later reattached to the new DOMWindow by calling ScriptController::updateDocument(). As an optimization, 246e25c skipped initialization of the WindowProxy if it's global proxy reference was null. Skipping initialization is safe here since a null global proxy reference means that ToV8() was never called, and JS cannot hold any references to the Window object. Thus, it is unnecessary to ensure that the global proxy is attached to a DOMWindow. 40458d4 cleaned up the complex WindowProxy initialization logic but introduced a subtle bug: it changed updateDocument() to be a no-op if the WindowProxy is not initialized. Unfortunately, this means that any existing script references to that Window object will be broken unless WindowProxy reinitialization is triggered by something else, such as loading a <script> tag in the new Document or getting a new reference to the Window. BUG=690178 Review-Url: https://codereview.chromium.org/2732483004 Cr-Commit-Position: refs/heads/master@{#454552} (cherry picked from commit bee44e2) Review-Url: https://codereview.chromium.org/2735983002 . Cr-Commit-Position: refs/branch-heads/3029@{#37} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

…ript (patchset #37 id:720001 of https://codereview.chromium.org/2653923008/ ) Reason for revert: Suspected to cause CHECK() failure (crbug.com/711703) inside PendingScript's prefinalizer. BUG=711703 Original issue's description: > Split PendingScript into PendingScript and ClassicPendingScript > > This is preparation for introducing ModulePendingScript. > > BUG=594639, 686281 > > Review-Url: https://codereview.chromium.org/2653923008 > Cr-Commit-Position: refs/heads/master@{#464494} > Committed: https://chromium.googlesource.com/chromium/src/+/d512803299c01324b92ffd8c962da97e3bc8ccff TBR=kouhei@chromium.org,sigbjornf@opera.com,japhet@chromium.org,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594639, 686281 Review-Url: https://codereview.chromium.org/2820753002 Cr-Commit-Position: refs/heads/master@{#464768} (cherry picked from commit 56f27b6) Review-Url: https://codereview.chromium.org/2827473002 . Cr-Commit-Position: refs/branch-heads/3071@{#18} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

The promo is currently being shown on second run because native initialization can finish before the FRE completes. Therefore the PROMOS_SKIPPED_ON_FIRST_START pref isn't set until the second run, and then the promo is shown on the third. BUG=672954 Review-Url: https://codereview.chromium.org/2824893002 Cr-Commit-Position: refs/heads/master@{#465085} (cherry picked from commit 147bd1e) Review-Url: https://codereview.chromium.org/2821393002 . Cr-Commit-Position: refs/branch-heads/3071@{#37} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

- Adds UseCounters to count presentations started on secure/insecure origins. - Logs a deprecation warning only when presentations are started, because of the warning frequency on PresentationRequest constructor or getAvailability. Blink-dev thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/lumj0lVdtHA/discussion TBR=mfoltz@chromium.org (cherry picked from commit f7bed1a) Bug: 733381 Change-Id: I4352b2b9d3e887ade122bb8efb6e9a8efcbfd874 Reviewed-on: https://chromium-review.googlesource.com/578687 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488681} Reviewed-on: https://chromium-review.googlesource.com/585612 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#37} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

This CL re-lands https://chromium-review.googlesource.com/643527 which imposed that Chrome is only available on devices that support landscape orientation. This CL fixes that by indicating that landscape orientation is not strictly required. Bug: 743150 Change-Id: Icff29de9e508dfd1654b2d842b2c211656929c97 Reviewed-on: https://chromium-review.googlesource.com/646627 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499759}(cherry picked from commit f09ae76) Reviewed-on: https://chromium-review.googlesource.com/651431 Reviewed-by: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#37} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

Problem: When a Text node, "hey" is within a link that is within |user-select: text|, <div style="user-select: text"><a href="">hey</a></div> The link text, "hey" should be draggable despite any user-select styling. Background: The bug surfaced because Node::CanStartSelection returns true for any node that is within a |user-select: text| sub tree. That made DragController::DraggableNode make the wrong decision (it returned nullptr for start_node = "hey"). Solution: With a new helper, SelectTextInsteadOfDrag we check if a dragged node is a selectable and undraggable Text node. Note: There can only be one Text node in the ancestor chain (because Text nodes cannot have children) so SelectTextInsteadOfDrag will only be called once. TBR=pdr@chromium.org (cherry picked from commit 2e2c1dd) Bug: 771573 Change-Id: Id482cf0888cd428d0bc9a12bff535743c7138df8 Reviewed-on: https://chromium-review.googlesource.com/705234 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Original-Commit-Position: refs/heads/master@{#508658} Reviewed-on: https://chromium-review.googlesource.com/723284 Reviewed-by: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/branch-heads/3239@{#37} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

Before this CL 1) for each user interaction there were 2 JS->C++ messages, instead of just 1. 2) the C++ call was made only after the drawer animation finished, which created a race condition between the inDevMode boolean and the toggle's state. Now it happens as soon as the user clicks. 3) The height of the cards was snapping after the toolbar animation finished. No longer the case. The height of the cards animates at the same time with the toolbar. This simplifies the logic a bit, and unblocks porting the PolicyTest.DeveloperToolsDisabledExtensionsDevMode to the new UI. TBR=dpapad@chromium.org (cherry picked from commit 9074e59) Bug: 803326 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f2995bc322f619fbc8fad812dd03344e895391c Reviewed-on: https://chromium-review.googlesource.com/874775 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530420} Reviewed-on: https://chromium-review.googlesource.com/881868 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#37} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

…in dtor DownloadFilePicker is a lisener of SelectFileDialog. When it creates a SelectFileDialog, it should inform the latter when it is killed. Otherwise, SelectFileDialog might hit NPE when calling the listener method. BUG=818066 Change-Id: Idc5e67b5cba9eac5f72b8e7a2df1ca70f2adbd8e Reviewed-on: https://chromium-review.googlesource.com/949099 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Joy Ming <jming@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541013}(cherry picked from commit 3ddb6c8) Reviewed-on: https://chromium-review.googlesource.com/952027 Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#37} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

…onManager Command-line switches that should be independent of policy/flag settings are now cached in UserSessionManager, so they're not lost when a different set of command-line switches is applied. Currently, the only such persistent switch is --profile-requires-policy set by UserCloudPolicyManagerChromeOS. The long-term plan is to further develop this mechanism in a way to make manual re-parsing of switches (see e.g. |KioskAppManager::GetSwitchesForSessionRestore|) unnecessary. This will be done in a follow-up CL. and manual: Enable IsolateOrigins user policy and ephemeral_user_enabled device policy, sign-in into a user account. TBR=pmarko@chromium.org (cherry picked from commit 2ed0db6) Bug: 831460 Test: browser_tests --gtest_filter=SiteIsolationFlagHandlingTest* Change-Id: I1276b20018b0c4305309123e46dd3411aeda5ac0 Reviewed-on: https://chromium-review.googlesource.com/1010343 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550765} Reviewed-on: https://chromium-review.googlesource.com/1014109 Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#37} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

https://chromium.googlesource.com/catapult.git/+log/0ceb1eccef76..393b0fd9c739 $ git log 0ceb1ecce..393b0fd9c --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu [Tracing UI] Use ResizeObserver for picture chart resizing Created with: roll-dep src/third_party/catapult BUG=chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com, sullivan@chromium.org (cherry picked from commit 4a160f0) Change-Id: I1a64cd37f4324f1a7e07e206129016c8dca424c0 Reviewed-on: https://chromium-review.googlesource.com/1073644 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/master@{#562019} Reviewed-on: https://chromium-review.googlesource.com/1077169 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#37} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

This change was dropped from https://chromium-review.googlesource.com/c/chromium/src/+/1102505 due to a bad merge. Add it back. R=eseckler@chromium.org TBR=altimin@chromium.org BUG=806271 (cherry picked from commit b2aba4e) Change-Id: I6dc5f83cfe61ccbad3069e7d194c1dc494909ff9 Reviewed-on: https://chromium-review.googlesource.com/1145437 Reviewed-by: Eric Seckler <eseckler@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577147} Reviewed-on: https://chromium-review.googlesource.com/1148394 Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#37} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

…rashes. There is no guarantee that the DocumentLoader is always attached [1], so let's introduce null checks in StateInternal and setScrollRestoration. [1] The DocumentLoader may be detached while FrameLoader::PrepareForCommit. BUG=879477, 872672 Change-Id: I048ad8ff3787fcead262c19fcdb485e9e5a5e3bf Reviewed-on: https://chromium-review.googlesource.com/1200075 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588227}(cherry picked from commit 27986c7) Reviewed-on: https://chromium-review.googlesource.com/1205104 Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#37} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

TBR=melandory@chromium.org (cherry picked from commit 5279e0f) Bug: 894764 Change-Id: If190cdf6396b567c9ab5e983d67d4f25b20d501b Reviewed-on: https://chromium-review.googlesource.com/c/1278787 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599500} Reviewed-on: https://chromium-review.googlesource.com/c/1283022 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#37} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

The fields are added to DRPPageLoadTiming and added to a submessage in the pingback to make server-side analysis easier. This also moves the ServerLitePageStatus enum out of PreviewsUserData and into a common header for sake of layering. Bug: 864665 Change-Id: I1844acd4f249397a70848a2d2c2b578e64a54034 Reviewed-on: https://chromium-review.googlesource.com/c/1356119 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613159}(cherry picked from commit b0b6e3e) Reviewed-on: https://chromium-review.googlesource.com/c/1361596 Reviewed-by: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#37} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

…ere: http://crbug.com/925796 [Autofill Assistant] Have controller track message and details. Before this change, the source of truth for the status message and the details was in the Java layer. The native layer would even call GetStatusMessage when it needed to keep the status message to restore it after some operations, such as running interrupts or asking for confirmation about inconsistent details. After this change, the Controller keeps track of the status message and and details and the UI layer know about changes by calling OnStatusMessageChange and OnDetailsChange. Logic for confirming the details is pushed down to the ShowDetails and separates displaying the details from asking for confirmation. This change is a step towards keeping enough state in the controller to be able to attach and detach a Controller to or from the UI layer, as part of the effort to run Autofill Assistant on any tab. This is a refactoring. It should not change existing behavior. Bug: 806868 Change-Id: Ifb5e9f4ac3228d2473a90400e1c3020fa1e2ffed Reviewed-on: https://chromium-review.googlesource.com/c/1426690 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626073}(cherry picked from commit 0c2746c) Reviewed-on: https://chromium-review.googlesource.com/c/1442721 Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#37} Cr-Branched-From: e510299-refs/heads/master@{#625896}

This CL adds metrics recording to the advanced sign-in flow. It modifies recordSyncSetupDataTypesHistogram to make sure that data types that can't be enabled on Android aren't recorded by UnifiedConsent.SyncAndGoogleServicesSettings.AfterAdvancedOptIn. SyncDataTypesOff. It also adds to this histogram a value that corresponds to the top-level Sync toggle. Bug: 933645 Change-Id: Idc7af68ae2a70cb8f48d6832e17370aa321d90d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509532 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#639468}(cherry picked from commit 02c8e27f40738e1cf224a5399d48fad27a666197) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517703 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#37} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

rogerwang and others added 2 commits August 4, 2016 06:30

nwjs master

143aee6

create new SiteInstance when using new_instance

a0aa609

fixed nwjs/nw.js#5163

rogerwang force-pushed the nw16 branch 2 times, most recently from f529e82 to 4fe31bb Compare August 22, 2016 01:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create new `SiteInstance` when using `new_instance`#37

create new `SiteInstance` when using `new_instance`#37
ghostoy wants to merge 2 commits intonwjs:nw16from
ghostoy:issue-5163

ghostoy commented Aug 5, 2016

Uh oh!

ghostoy commented Nov 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ghostoy commented Aug 5, 2016

Uh oh!

ghostoy commented Nov 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants