[AutoUpdater][OSX] add squirrel auto updater#5722
Conversation
|
Great. Thanks! Will look to merge it. CC #233 |
|
Please include documentation change as well. |
|
ok @rogerwang, will do it within this 1-2days |
891b9c9 to
c64d2b6
Compare
c64d2b6 to
e283dd9
Compare
|
the documentation is done (included in this pull request) |
|
I see the docs comes from http://electron.atom.io/docs/api/auto-updater/ with modifications. After PR merged, is NW supposed to work in the same way as described in the doc? There are several external tools mentioned in the doc, including electron-winstaller, electron-builder, grunt-electron-installer, nuts, squirrel-updates-server, squirrel-release-server. Are they tested to work with this PR? -- just want to know what has already been tested on your side and I'll try the others. |
|
@rogerwang my implementation was closely following the electron api, with very little modification. as for the windows installer, I personally have tried electron-wininstaller, and it works with nw.js as for the server, I was trying squirrel-updates-server, but it is too complicated for my test / needs |
|
Is this going to be integrated into nw.js anytime soon? Would be great to have squirrel delta updates, but if not will roll my own updater... |
|
@rogerwang do you think this can land any time soon? 🙏🏻 |
|
@sashahilton00 did you manage to create your solution for delta updates ? |
|
@rogerwang Any update on when are you merging the PR? Auto update, specifically delta updates is crucial for a desktop app. This functionality alone could be a deal breaker when choosing between nwjs OR electron. |
|
@rogerwang any updates on this ? This is a must for my use case as i don't need to update nw binary itself, just the app code. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Roger Wang, this is my pull request for the auto updater
this will also needs nwjs/chromium.src#66
The squirrel windows auto update is included, in this commit
the windows version can be done in javascript only, it will do IPC with the squirrel updater