Skip to content

feat/ntm: NIP-13 Exit policy upgrade - #6959

Merged
serinko merged 2 commits into
developfrom
serinko/ntm-nim-13
Jul 21, 2026
Merged

feat/ntm: NIP-13 Exit policy upgrade#6959
serinko merged 2 commits into
developfrom
serinko/ntm-nim-13

Conversation

@serinko

@serinko serinko commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This PR adds ports from NIP-13 to Exit policy managed by operators through NTM


This change is Reviewable

Summary by CodeRabbit

  • Updates
    • Updated network tunnel port access rules for supported services.
    • Added or revised access for Zoom, WhatsApp, Rainbow Six Siege, Epic Games, and metadata services.
    • Adjusted several service port ranges and removed access to certain previously permitted ports.

@serinko serinko added this to the Independent Release milestone Jul 20, 2026
@serinko serinko self-assigned this Jul 20, 2026
@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nym-explorer-v2 Ready Ready Preview, Comment Jul 20, 2026 12:40pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs-nextra Ignored Ignored Jul 20, 2026 12:40pm
nym-node-status Ignored Ignored Jul 20, 2026 12:40pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The WireGuard exit-policy allowlist in apply_port_allowlist updates service port mappings, activates selected Zoom, WhatsApp, RainbowSixSiege2, EpicGames1, and Metadata entries, and comments out redundant mappings with an explanatory governance note.

Changes

WireGuard exit port allowlist

Layer / File(s) Summary
Targeted service mapping updates
scripts/nym-node-setup/network-tunnel-manager.sh
Adds the governance comment and updates selected Zoom, WhatsApp, SMTP, SteamGaming, RainbowSixSiege, WorldOfWorldcraft, and MQTTS mappings.
Broader active policy rewrite
scripts/nym-node-setup/network-tunnel-manager.sh
Updates RainbowSixSiege2, comments out numerous high-numbered service mappings, and adds or retains entries including EpicGames1 and Metadata.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • nymtech/nym#6807: Updates the same apply_port_allowlist WireGuard service-to-port mappings.

Suggested reviewers: benedettadavico

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: updating NTM exit policy ports for NIP-13.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch serinko/ntm-nim-13

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/nym-node-setup/network-tunnel-manager.sh`:
- Around line 929-937: Reactivate PORT_MAPPINGS entry RainbowSixSiege1 at
scripts/nym-node-setup/network-tunnel-manager.sh lines 929-937. Also reactivate
MQTTS at lines 952-954, and keep DiscordVoiceChat1’s uncovered 65001-65535
portion active at lines 967-1004; preserve the existing governance grouping
comments and mapping structure.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c546058a-c4ff-42ca-99b1-9c9d86f78d8c

📥 Commits

Reviewing files that changed from the base of the PR and between 9dfc933 and e7dec42.

📒 Files selected for processing (1)
  • scripts/nym-node-setup/network-tunnel-manager.sh

Comment thread scripts/nym-node-setup/network-tunnel-manager.sh
@serinko
serinko merged commit edb546c into develop Jul 21, 2026
10 checks passed
@serinko
serinko deleted the serinko/ntm-nim-13 branch July 21, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants