update nym-node-cli#6964
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe node setup flow now derives WireGuard-aware installation capabilities, retrieves scripts with retrying HTTPS requests, configures prerequisites and UFW through separate stages, and conditionally provisions nginx, HTTPS, WSS, tunnel, WireGuard, and QUIC components. ChangesNode setup installation
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant NodeSetupCLI
participant PrerequisitesScript
participant NginxWssScript
participant Certbot
participant Nginx
NodeSetupCLI->>PrerequisitesScript: install prerequisites
PrerequisitesScript-->>NodeSetupCLI: dependencies ready
NodeSetupCLI->>NginxWssScript: run conditional nginx and WSS setup
NginxWssScript->>Certbot: request certificate
Certbot-->>NginxWssScript: return certificate status
NginxWssScript->>Nginx: enable HTTPS and WSS when certificate exists
NginxWssScript-->>NodeSetupCLI: report HTTP, HTTPS, and WSS status
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
serinko
marked this pull request as ready for review
July 21, 2026 11:09
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/nym-node-setup/nym-node-prereqs-install.sh`:
- Around line 8-29: Enable fail-fast behavior near the start of
nym-node-prereqs-install.sh, before the apt update, upgrade, and core dependency
installation commands, so failures in those hard requirements terminate the
script. Preserve the existing explicit || true and conditional guards for
intentional recovery and optional fallbacks.
In `@scripts/nym-node-setup/setup-nginx-proxy-wss.sh`:
- Around line 108-127: Update the HTTP vhost generation around HTTP_CONF so the
location / behavior is chosen after checking whether the certificate exists:
redirect to HTTPS only when the certificate is available, otherwise serve the
configured WEBROOT with index.html over plain HTTP. Keep the ACME challenge
location reachable in both cases and ensure the certificate check occurs before
writing the vhost.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: eb47eb42-fbaf-4982-88d7-c00f43ab1010
📒 Files selected for processing (3)
scripts/nym-node-setup/nym-node-cli.pyscripts/nym-node-setup/nym-node-prereqs-install.shscripts/nym-node-setup/setup-nginx-proxy-wss.sh
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@documentation/docs/pages/operators/tools.mdx`:
- Around line 81-84: Update the command example around nym-node-cli.py so the
optional --dev argument remains part of a valid shell command. Move the
development comment outside the continued command, or add a separate complete
command example that includes --dev, ensuring uncommenting it passes the option
to nym-node-cli.py rather than executing it independently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f4d26880-0375-4ac9-9e77-f92c0193c5e8
📒 Files selected for processing (3)
documentation/docs/pages/operators/tools.mdxscripts/nym-node-setup/nym-node-prereqs-install.shscripts/nym-node-setup/setup-nginx-proxy-wss.sh
🚧 Files skipped from review as they are similar to previous changes (2)
- scripts/nym-node-setup/nym-node-prereqs-install.sh
- scripts/nym-node-setup/setup-nginx-proxy-wss.sh
merve64
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance of nym-node-cli and debugging some logic issues to make the tool work properly
This change is
Summary by CodeRabbit