Repository navigation
fix(deploy): surface loopback-only Docker ports for review - #1131
Open
Metehan-Bicer wants to merge 4 commits into
Open
Metehan-Bicer wants to merge 4 commits into
Metehan-Bicer wants to merge 4 commits into
Conversation
The port check read /proc/net/tcp inside the container but kept only the port of each LISTEN row, so an app bound to 127.0.0.1 counted as listening although the edge, which reaches a Docker deployment through the container's own address, gets no answer. On the docker runtime such a port now logs a warning instead of "is listening"; the result stays listening, and the bare runtime is unchanged. Refs oblien#1022
Hydralerne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Docker app can listen successfully on container loopback while requests through its published route fail. Report that confirmed binding problem as Action required through the existing deployment port review and Monitoring. The release remains running.
The review explains how to configure the app or route to its intended proxy and links to its settings. The existing wrong-port editor remains available for missing listeners. Partial-deployment decisions are handled before port review, so those dialogs do not open together. The Domains page uses the same diagnosis for its live port hint.
Changes
Validation
bun run test: 10 successful tasks, 19,890 tests passed and 7 existing skips.bun run docs:checkpassed: documentation links, shared API/MCP reference, built CLI help and all CLI/SDK examples.The added regressions reproduced incomplete socket-read false positives, dropped binding results, and missing pending actions/build-page status on the previous implementation. Database tests use real PGlite for concurrent dismissals and metadata/status preservation.
Related issue
Addresses the loopback-binding diagnosis in #1022. This change reports the condition; it does not automatically reconfigure an application or create a proxy.