Skip to content

fix: treat disable directives naming unloaded rules as inconclusive - #32

Open
mnaoumov wants to merge 2 commits into
obsidianmd:mainfrom
mnaoumov:fix/unknown-rule-directives
Open

mnaoumov wants to merge 2 commits into
obsidianmd:mainfrom
mnaoumov:fix/unknown-rule-directives

Conversation

@mnaoumov

@mnaoumov mnaoumov commented Nov 6, 2026

Copy link
Copy Markdown

Fixes #31

A disable comment for a rule from a plugin the scanner does not load, such as

// eslint-disable-next-line typescript-dev-toolkit/readonly-interface-members -- Local lint convention.

makes ESLint report "Definition for rule '...' was not found." with that rule's id and severity 2. parseEslintOutput only treats fatal or null-ruleId messages as execution problems, so this one became a failed policy error, though the rule never ran.

This change recognises that message when the rule it names is the message's own ruleId, and reports it as eslint-unknown-rule-directive with status inconclusive, the same way fatal diagnostics are handled. Everything else from the file is unchanged.

The new test uses the exact output of ESLint 9.37.0 (the version the scanner pins) for that comment placed above eval('1'): the directive message becomes inconclusive and the no-eval error stays an error. A second test checks that a real rule finding whose text merely looks like a missing definition is not reclassified.

npm run format:check, npm run lint and npm test pass, and dist/ is rebuilt in a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scanner ESLint reports policy errors for disable comments naming unloaded rules

1 participant