Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
A disable comment for a rule from a plugin the scanner does not load, such as
// eslint-disable-next-line typescript-dev-toolkit/readonly-interface-members -- Local lint convention.makes ESLint report "Definition for rule '...' was not found." with that rule's id and severity 2. parseEslintOutput only treats fatal or null-ruleId messages as execution problems, so this one became a failed policy error, though the rule never ran.
This change recognises that message when the rule it names is the message's own ruleId, and reports it as eslint-unknown-rule-directive with status inconclusive, the same way fatal diagnostics are handled. Everything else from the file is unchanged.
The new test uses the exact output of ESLint 9.37.0 (the version the scanner pins) for that comment placed above
eval('1'): the directive message becomes inconclusive and the no-eval error stays an error. A second test checks that a real rule finding whose text merely looks like a missing definition is not reclassified.npm run format:check,npm run lintandnpm testpass, and dist/ is rebuilt in a separate commit.