Skip to content

Conversation

@Taeski-SOOP
Copy link

※ I'm requesting a new one because the commit arrangement is complicated. (Previous Request #11428)

Description

Effective October 15th, our service has been rebranded from Afreecatv to SOOP Korea.
We are planning to change the server URL of AfreecaTV to SOOP Korea.

Motivation and Context

We aim to adapt the current Afreecatv configurations to be compatible with SOOP.

How Has This Been Tested?

Locally tested and is working properly.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@norihiro
Copy link
Contributor

In the commit message,

  1. Remove a space between rtmp-services and :.
  2. The description line should be folded so that one line contains at most 72 characters.

To revise the commit message, use git commit --amend to edit the message. Then, use git push -f to force-push to GitHub.

@Taeski-SOOP Taeski-SOOP force-pushed the feature/taeski-soop-obs branch from 143ed45 to 7f2dd23 Compare November 25, 2024 02:58
@Taeski-SOOP Taeski-SOOP changed the title rtmp-services : Change the server URL of AfreecaTV to SOOP Korea rtmp-services: Change the server URL of AfreecaTV to SOOP Korea Nov 25, 2024
@Taeski-SOOP
Copy link
Author

@norihiro I revised it and force-push. Thank you for the guide.

@RytoEX RytoEX added the Services These are modifications to the Service list and are not tied to the release schedule label Jul 22, 2025
Copy link
Member

@Fenrirthviti Fenrirthviti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on eligibility.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question on service name. Everything else seems fine.

@RytoEX RytoEX force-pushed the feature/taeski-soop-obs branch from 7f2dd23 to 620a258 Compare October 31, 2025 17:42
Request a code modification due to the change of AfreecaTV name.

Effective October 15 2024, AfreecaTV has been rebranded to SOOP Korea.
@RytoEX RytoEX force-pushed the feature/taeski-soop-obs branch from 620a258 to bd2df68 Compare November 4, 2025 20:13
@RytoEX RytoEX merged commit c835bc5 into obsproject:master Nov 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Services These are modifications to the Service list and are not tied to the release schedule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants