-
Notifications
You must be signed in to change notification settings - Fork 455
Doc page about using opam by default with dune pkg #12761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc page about using opam by default with dune pkg #12761
Conversation
|
Instead of setting contexts, wouldn't it be more useful to advertise |
|
I would also rather advertise |
2c77694 to
2252ef8
Compare
|
It is however possible if a person wishes to contribute to a repo that has a checked in lock file but they may wish to continue to use opam. |
|
Ok updated to use autolocking instead of lockdirs. |
|
|
||
| With these two files in place, by default Dune will use the specified Opam | ||
| switch to resolve your project's dependencies. However, setting the environment | ||
| variable ``DUNE_WORKSPACE=dune-workspace.pkg`` will cause Dune to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also possible to do this using the --workspace cli option. But I'm not sure if its worth going into all this detail about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a line about the CLI flag is probably good, because users of either strategy are likely to want to test or try the other in one-off commands.
|
Do we have any genuine reasons other than not wanting to change for using opam? The existence of this tutorial might be confusing without the proper motivation. |
This is a good question. I think this tutorial is useful because a large chunk of users of |
|
OK what about this. We should add a paragraph stating that we are interested in knowing what can be done with opam that can't with dune pkg for local development. If there is something we are not aware of, we should definitely ask about it. Opening an issue etc. |
| @@ -0,0 +1,41 @@ | |||
| How to Use Opam Alongside Dune Package Management | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lovely solution!
|
@Alizter see quantifyearth/container-image#7 (review) and the following discussion for context.
IMO, this needlessly complicates the documentation here. AFAIU, we all agree dune must continue to support non dune-pkg development workflows (at least in the near to midterm future), and so we should make it easy for people who want to manage dependencies with opam to do so. I don't think we need to situate it as a resource contention or complicate the docs on how to do that easily with nudges to use |
43b5726 to
d6d64ea
Compare
Signed-off-by: Stephen Sherratt <[email protected]>
e907bcb to
f5de90d
Compare
|
This doesn't seem to actually work though... I assume this needs |
Would be nice to have an informative error message here about that. |
|
Thanks @Alizter! However, it doesn't work in the dune-workspace file either; the presence of a dune.lock seems to always activate dune package management for me. |
|
@avsm Yes, unfortunately this is a bug with |
No description provided.