Skip to content

[Design] Proposal for Parameterized Query Interface#128

Open
zamaoxiaoji wants to merge 3 commits intooceanbase:developfrom
zamaoxiaoji:feature/issue-83
Open

[Design] Proposal for Parameterized Query Interface#128
zamaoxiaoji wants to merge 3 commits intooceanbase:developfrom
zamaoxiaoji:feature/issue-83

Conversation

@zamaoxiaoji
Copy link

Task Description

The current embedded SQL execution interface (ObSPIService) only supports SQL string parameters:

Solution Description

Implement a parameterized query interface similar to pymysql

Passed Regressions

  • Test all parameter types
  • Test SQL injection prevention
  • Test placeholder count validation
  • Test error handling

Upgrade Compatibility

  • Fully backward compatible with existing interfaces
  • No changes to existing APIs
  • New interfaces are additions only

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2026

CLA assistant check
All committers have signed the CLA.

@hnwyllmm
Copy link
Member

It's wonderful. Let's dive deep into this.

@zamaoxiaoji
Copy link
Author

Hi! I have placed the specific document under docs/design and also pushed the code for the second time. Do I need to submit a new PR for the code? @hnwyllmm

@hnwyllmm
Copy link
Member

hnwyllmm commented Jan 23, 2026

Hi! I have placed the specific document under docs/design and also pushed the code for the second time. Do I need to submit a new PR for the code? @hnwyllmm

It's OK. But it takes time to review the design. I'll start the work at the next week Thursday.

@LINxiansheng
Copy link
Member

The code is too larger so we need more time to review it.
Maybe we can wait next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants