[Design] Proposal for Parameterized Query Interface#128
Open
zamaoxiaoji wants to merge 3 commits intooceanbase:developfrom
Open
[Design] Proposal for Parameterized Query Interface#128zamaoxiaoji wants to merge 3 commits intooceanbase:developfrom
zamaoxiaoji wants to merge 3 commits intooceanbase:developfrom
Conversation
3cfedce to
72f954b
Compare
Member
|
It's wonderful. Let's dive deep into this. |
Author
|
Hi! I have placed the specific document under docs/design and also pushed the code for the second time. Do I need to submit a new PR for the code? @hnwyllmm |
Member
It's OK. But it takes time to review the design. I'll start the work at the next week Thursday. |
Member
|
The code is too larger so we need more time to review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
The current embedded SQL execution interface (
ObSPIService) only supports SQL string parameters:Solution Description
Implement a parameterized query interface similar to pymysql
Passed Regressions
Upgrade Compatibility