Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/components/c2d/compute_engine_docker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@ export class C2DEngineDocker extends C2DEngine {
try {
const dockerImage = this.docker.getImage(image)
await dockerImage.remove({ force: true })
await this.db.deleteImage(image)
cleaned++
CORE_LOGGER.info(`Successfully removed old image: ${image}`)
} catch (e) {
Expand Down Expand Up @@ -1826,16 +1827,6 @@ export class C2DEngineDocker extends C2DEngine {
} catch (e) {
CORE_LOGGER.error('Container volume not found! ' + e.message)
}
if (job.algorithm?.meta.container && job.algorithm?.meta.container.dockerfile) {
const image = getAlgorithmImage(job.algorithm, job.jobId)
if (image) {
try {
await this.docker.getImage(image).remove({ force: true })
} catch (e) {
CORE_LOGGER.error('Could not delete image: ' + image + ' : ' + e.message)
}
}
}
try {
// remove folders
rmSync(this.getC2DConfig().tempFolder + '/' + job.jobId + '/data/inputs', {
Expand Down Expand Up @@ -2136,6 +2127,9 @@ export class C2DEngineDocker extends C2DEngine {
await new Promise<void>((resolve, reject) => {
buildStream.on('end', () => {
CORE_LOGGER.debug(`Image '${job.containerImage}' built successfully.`)
this.updateImageUsage(job.containerImage).catch((e) => {
CORE_LOGGER.debug(`Failed to track image usage: ${e.message}`)
})
resolve()
})
buildStream.on('error', (err) => {
Expand Down
4 changes: 4 additions & 0 deletions src/components/database/C2DDatabase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ export class C2DDatabase extends AbstractDatabase {
return await this.provider.updateImage(image)
}

async deleteImage(image: string): Promise<void> {
return await this.provider.deleteImage(image)
}

async getOldImages(retentionDays: number): Promise<string[]> {
return await this.provider.getOldImages(retentionDays)
}
Expand Down
17 changes: 17 additions & 0 deletions src/components/database/sqliteCompute.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,23 @@ export class SQLiteCompute implements ComputeDatabaseProvider {
})
}

deleteImage(image: string): Promise<void> {
const deleteSQL = `
DELETE FROM docker_images WHERE image = ?;
`
return new Promise<void>((resolve, reject) => {
this.db.run(deleteSQL, [image], (err) => {
if (err) {
DATABASE_LOGGER.error(`Could not delete image ${image}: ${err.message}`)
reject(err)
} else {
DATABASE_LOGGER.debug(`Deleted image ${image}`)
resolve()
}
})
})
}

getOldImages(retentionDays: number = 7): Promise<string[]> {
const cutoffTimestamp = Math.floor(Date.now() / 1000) - retentionDays * 24 * 60 * 60
const selectSQL = `
Expand Down
Loading