[FIX] html_editor: properly preserve selection in textareas #4885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invisible whitespace that would become visible in a `<pre>` element should be removed before turning a block into a `<pre>`. task-5262154
This commit addresses a bug that can be reproduced as follows: 1. Create a list before or after a paragraph 2. Indent the list 3. Insert a code block in it 4. Type in the code block -> the selection is ejected from the code block. The issue was due to `preserveTextareaSelections`: its condition to restore the focus within a textarea was never met. As a result, when the active selection was changed during normalization, the focus was lost. Fixing this revealed a double issue with the `undo` and `redo` functions: 1. the focus should be set _before_ setting the selection (otherwise changing the focus might change the selection back) 2. `body.focus()` doesn't do anything, we need to do `editable.focus()`. task-5262154
|
This PR targets the un-managed branch odoo-dev/odoo:19.0-syntax_highlighting_readonly-age, it needs to be retargeted before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug that can be reproduced as follows:
-> the selection is ejected from the code block.
The issue was due to
preserveTextareaSelections: its condition to restore the focus within a textarea was never met. As a result, when the active selection was changed during normalization, the focus was lost.Fixing this revealed a double issue with the
undoandredofunctions:body.focus()doesn't do anything, we need to doeditable.focus().While fixing the issue, an unrelated problem was noticed and also addressed here: invisible whitespace that would become visible in a
<pre>element should be removed before turning a block into a<pre>.task-5262154