[FIX] {*}: fix various bugs #1412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
trcazier
force-pushed
the
master-hr-issues-fix-trcaz
branch
3 times, most recently
from
673f8ef to
4acd107
Compare
vava-odoo
reviewed
Dec 1, 2025
Collaborator
vava-odoo
left a comment
vava-odoo
left a comment
There was a problem hiding this comment.
Looks good. Just a few remarks.
Also, could you explain and add the link to the standard change in the commit messages directly?
trcazier
force-pushed
the
master-hr-issues-fix-trcaz
branch
2 times, most recently
from
7f2ff66 to
be82e44
Compare
vava-odoo
reviewed
Dec 1, 2025
Caused by: odoo/odoo@e5fa13d Removal of default admin user makes everything without an admin fail. Dropped hr prefix everywhere and, depending on the Industry module: - moved admin creation from hr_employee to hr_department - added an admin user or - moved it from data to demo
Caused by: odoo/odoo@9afc02f Field name changed: is_published -> website_published in `website.published.mixin`
Caused by: odoo/odoo@8b1ece1 Field name changed: date_published -> published_date in `slide.slide`
Caused by: odoo/odoo@3081bcd `sequence_code` being processed differently made domains with 'sequence_code', '=', 'XXX' not capture the proper elements. Fixed said domains and fixed industries setting their own sequence codes/route prefixes so they display correctly
trcazier
force-pushed
the
master-hr-issues-fix-trcaz
branch
from
be82e44 to
0aa7eeb
Compare
Collaborator
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Dec 2, 2025
Caused by: odoo/odoo@e5fa13d Removal of default admin user makes everything without an admin fail. Dropped hr prefix everywhere and, depending on the Industry module: - moved admin creation from hr_employee to hr_department - added an admin user or - moved it from data to demo Part-of: #1412 Signed-off-by: Vallaeys Valentin (vava) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Dec 2, 2025
Caused by: odoo/odoo@9afc02f Field name changed: is_published -> website_published in `website.published.mixin` Part-of: #1412 Signed-off-by: Vallaeys Valentin (vava) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Dec 2, 2025
Caused by: odoo/odoo@8b1ece1 Field name changed: date_published -> published_date in `slide.slide` Part-of: #1412 Signed-off-by: Vallaeys Valentin (vava) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Dec 2, 2025
Caused by: odoo/odoo@3081bcd `sequence_code` being processed differently made domains with 'sequence_code', '=', 'XXX' not capture the proper elements. Fixed said domains and fixed industries setting their own sequence codes/route prefixes so they display correctly closes #1412 Signed-off-by: Vallaeys Valentin (vava) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits responsible:
Removal of default admin user makes everything without an admin fail
Field name changed is_published -> website_published in website.published.mixin
Field name changed date_published -> published_date in slide.slide
sequence_code processed differently made domains with
'sequence_code', '=', 'XXX'not capture the proper elementstask-5361284