[FIX] util/fields: clean sort in filters

In the remove_field, sort is not cleaned up when filters are
cleaned. It sometimes can lead to post upgrade issues if someone
uses a removed field for their custom filter.

closes #52

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: asno-odoo

src/util/fields.py

@@ -154,6 +154,28 @@ def clean_context(context):
         if changed:
             add_to_migration_reports(("ir.filters", id_, name), "Filters/Dashboards")
 
+    if column_exists(cr, "ir_filters", "sort"):
+        cr.execute(
+            """
+               WITH to_update AS (
+                   SELECT f.id,
+                          COALESCE(ARRAY_TO_JSON(ARRAY_AGG(s.sort_item ORDER BY rn) filter (WHERE s.sort_item not in %s)), '[]') AS sort
+                     FROM ir_filters f
+                 JOIN LATERAL JSONB_ARRAY_ELEMENTS_TEXT(f.sort::jsonb)
+                       WITH ORDINALITY AS s(sort_item, rn)
+                          ON true
+                       WHERE f.model_id = %s
+                         AND f.sort ~ %s
+                  GROUP BY id
+               )
+               UPDATE ir_filters f
+                  SET sort = t.sort
+                 FROM to_update t
+                WHERE f.id = t.id
+            """,
+            [(fieldname, fieldname + " desc"), model, r"\y{}\y".format(fieldname)],
+        )
+
     def adapter(leaf, is_or, negated):
         # replace by TRUE_LEAF, unless negated or in a OR operation but not negated
         if is_or ^ negated: