Repository navigation
prov/efa: Make sure resources are freed before destroying domain - #13010
Open
mthyoung-amzn wants to merge 1 commit into
Open
mthyoung-amzn wants to merge 1 commit into
mthyoung-amzn wants to merge 1 commit into
Conversation
yinliaws
previously approved these changes
Oct 14, 2026
Contributor
|
why not just return EBUSY when the domain's refcnt is nonzero? |
mthyoung-amzn
force-pushed
the
fi_close_domain_check_empty
branch
2 times, most recently
from
October 14, 2026 23:41
94308c3 to
61faa36
Compare
mthyoung-amzn
changed the title
We were not tracking MRs along other domain resources, and were not checking that they were freed before cleaning up domains in fi_close(). This adds reference tracking of MRs (properly accounting for the internally-allocated zero-byte bounce buffer), and adds a precondition check that all application-allocated references have been freed. If not, return early with -FI_EBUSY, per the spec. Signed-off-by: Mitchell Young <mthyoung@amazon.com>
mthyoung-amzn
force-pushed
the
fi_close_domain_check_empty
branch
from
October 14, 2026 23:45
61faa36 to
a8201af
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not tracking MRs along other domain resources, and were not
checking that they were freed before cleaning up domains in fi_close().
This adds reference tracking of MRs (properly accounting for the
internally-allocated zero-byte bounce buffer), and adds a precondition
check that all application-allocated references have been freed. If not,
return early with -FI_EBUSY, per the spec.