Merged
Conversation
added 9 commits
March 4, 2026 14:55
saves about 300MB in the docker images, since it is now possible to used pnpm install --prod
pdubroy
reviewed
Mar 5, 2026
Contributor
pdubroy
left a comment
pdubroy
left a comment
There was a problem hiding this comment.
I'm not at all a Docker expert but this mostly lgtm.
Can we move most of these files that are currently in the root into a /docker directory?
Note: careful when running `git clean` ie ``` git clean -x -d -f docker compose build --no-cache ```
commit: |
Contributor
|
@millergarym I fixed up the CI issue, also moved everything into a docker/ dir in the repo root. Can you take one last look, and if everything looks good, I can merge it tomorrow. |
… is ohmjs-ohm (not docker-ohm)
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.