lang-python: fix unparse roundtrip check in bench.ts#583
Merged
Conversation
The CST is built from tokenized input (where comments are replaced with spaces), so reconstructing the full source requires using tokenizedInput for the prefix before the root node, not the raw input.
commit: |
pdubroy
force-pushed
the
pdubroy/fix-python-unparse
branch
from
5d879b9 to
b4a49b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the unparse roundtrip check in the Python benchmark. The CST is built from tokenized input (where comments are replaced with spaces), so reconstructing the full source now correctly uses the tokenized input for the prefix before the root node instead of the raw input.