Enhance Docker Certbot Integration and nginx Configuration#8
Open
Nave-Cohen wants to merge 3 commits into
Open
Enhance Docker Certbot Integration and nginx Configuration#8Nave-Cohen wants to merge 3 commits into
Nave-Cohen wants to merge 3 commits into
Conversation
…directories - Modify the script to generate and store self-signed certificates in domain-specific directories (`/etc/letsencrypt/$DOMAIN_MAIN/self-signed/`). - Update pre_hook to create symbolic links to domain-specific self-signed certificates. - Update deploy_hook to create symbolic links to domain-specific actual certificates. - Ensure compatibility with a single Nginx container mounting `/etc/letsencrypt` volume for serving multiple domains. - Prevent overwriting and conflicts by managing certificates independently for each domain. This change enhances the flexibility and robustness of the Certbot Docker setup, allowing for reliable and isolated management of certificates for multiple domains, ensuring that each domain's certificates are handled without conflicts.
- Removed the pinned version dependency for curl in the build configuration. - Previous version caused build failures due to compatibility or installation issues. - Updating to a more flexible version to ensure successful builds. This change resolves build errors encountered due to the specific version dependency of curl, ensuring smoother and reliable build processes.
Updated examples to emphasize using the first domain from the DOMAIN variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request enhances Docker Certbot integration and nginx configuration for improved SSL certificate management and web server setup.
Changes Made
Docker Certbot Integration:
nginx Configuration:
DOMAINSvariable in examples.Purpose
The updates aim to streamline SSL certificate management and nginx setup, making deploying and managing secure web services easier with Docker and Certbot.