externalInfo display#613
Conversation
sbesson
left a comment
There was a problem hiding this comment.
@will-moore thanks for starting this conversation. As noted above, Glencoe is using ExternalInfo quite extensively so we are interested in ways to expose this metadata via the OMERO.web API and/or UI.
Starting with with your last question, my immediate feeling is that it would be most beneficial to include this functionality in the OMERO.web JSON API. A few reasons for that:
- as explained in https://omero.readthedocs.io/en/stable/developers/Web.html, the
/webclientcomponent should be considered as internal only. If the intent is to expose this metadata as JSON for consumption (both internal and external),api/is the location of choice omero-marshalalready has support forExternalInfoencoding/decoding so there is no complex cross-component work- the usage of
ExternalInfois not limited toImageand can be applied to any object. Glencoe uses this onMaskobjects to represent labels for instance. Havingapi/v0/<images,rois,...>/<id>loading and exposing the external info in a unified manner would be consistent.
On the query itself, my impression is that externalInfo should be treated the same way as other details. I don't expect the additional join to be expensive in terms of query time given these are relatively shallow objects with only a few attributes but that should certainly be reviewed as par of the functional testing.
The UI questions is probably the one where I am the less opinionated and I have a suspicion the answer might be "it depends". For Zarr data, we have used ExternalInfo as an mechanism to store the location of the data. The closest equivalent would be the legacy OMERO pyramids which are not exposed in the UI. The most relevant existing icon would be the ../../. in the right-hand panel which lists the Fileset entries.
However other ExternalInfo objects might be more naturally suited either as Image details or as additional attributes
|
Agree with @sbesson; I would probably not create a separate view for retrieving |
ff2eab8 to
cac3aa7
Compare
|
@sbesson This is now deployed on idr-testing. e.g. https://idr-testing.openmicroscopy.org/webclient/?show=image-15160031 |
|
As a quick sidenote before I disappear for a week, I'd be more than happy if we hide the acronym "LSID" from users. |
|
👍 Looks good to me. What does LSID actually stand for, and what is the ExternalInfo actually used for generally @joshmoore ? |
|
LSID stands for "Life Science Identifier". https://www.lsid.info/ et al. https://zenodo.org/records/46804 is a pretty good read. The ExternalInfo object wasn't used a lot previously but was intended to hold info of the objects that felt "too detailed" to expose in the main object. It also helps that if you have an opaque identifier that you don't have to check every table to find the object but you can look in the one external info table. |
|
https://en.wikipedia.org/wiki/LSID. Do we use another term or just e.g. |
"Attribues"? "Attachments"? 😄
I certainly worry about CLI users less. But if we need to keep it, that's fine, just more than the other terms, "LSID" was a mistake. |
|
As discussed in web meeting, we probably don't want |
|
Deployed latest changes to idr-testing and updated screenshot above. |
|
To help testing, you can now set ExternalInfo via the CLI - see ome/omero-py#453 |
|
In IDR (and regular OMERO if/when omero-zarr-pixel-buffer becomes adopted) we want it to be nice and easy for a user to get the OME-Zarr URL for an image they are looking at, as they can do for e.g. https://idr.github.io/ome-ngff-samples/. We probably don't want to show "External Info" or |
|
As discussed in web meeting today:
|
|
As discussed with @jburel... Since we have addressed s3 backend issues in omero-zarr-pixel-buffer, we can expect to use genuine public URLs for external-info, so this should be easier for the user to find. This also gives us the chance to add "Open with" various zarr viewers. |
|
Note that everything that is discussed is conditional to the fact the
Not sure I understand. Unlike the
At least, this should be correct for Amazon S3. The service supports to types of requests: Path-style requests and Virtual-hosted–style requests. So
If the intent is to create an HTTP URL using by any a third-party application, then such transformation is probably only applicable to public data. No query parameter in a S3 |
|
@will-moore we cannot change the value to https or remove anonymous as @sbesson indicated. We only discussed showing external info to help identifying the "registered" one not reformatting it. to use it in the web, the application will need to parse it |
|
I understand that omero-web will need to parse it - I'm just asking if it will always work to replace |
Definitely not in the general case. |
|
@dominikl How do you like the current |
|
Thanks Will! Looks good to me! I think this would great to have on IDR, makes it so much easier to quickly check where an image is actually coming from! 👍 |
|
@knabar As discussed, I've cleaned this up a bit. Still using "Zarr" rather than ExternalInfo to display this to users. |
|
The two places referencing externalInfo can be changed now with #483 merged
Otherwise I think everything looks good! |
|
OK, should be good now. Needed a bit of extra code since you can't do |
| {% endif %} | ||
|
|
||
| <!-- External Info (Zarr url)--> | ||
| {% with extinfo=manager.external_info %} |
There was a problem hiding this comment.
An Image with an associated ExternalInfo object is not necessarily an OME-Zarr dataset. You will want to filter ExternalInfo objects of the correct namespace.
Also should this be called OME-Zarr rather than just Zarr as the group is expected to adhere to the multiscales metadata conventions of the OME-Zarr specification?
There was a problem hiding this comment.
By namespace do you mean entityType or entityId?
"Should be called OME-Zarr" where? In the UI Zarr button? I just think that OME-Zarr for this button would be a bit verbose, given the limited space for the toolbar.
But I'll certainly put "OME-Zarr Info" instead of "Zarr Info" in the panel below.
There was a problem hiding this comment.
Yes I meant entityType/entityId. OME-Zarr info would be a good starting point
There was a problem hiding this comment.
OK, now we only show Zarr button if the entityType and entityId indicate it's a "zarr" externalInfo.
|
@sbesson As discussed: removed the check on Could we include this in the next milestone? |
|
Thanks @will-moore, with the OMERO.web 5.31.1 patch release completed, I think it's reasonable to evaluate this proposal for the next milestone. Could you amend the description of the PR to reflect the latest state of the proposal and include updated screenshots? Which reviewers would you suggest in addition to @knabar and myself to represent the functional perspective from IDR? One high-level concern is that this PR exposes the content of a namespaced ExternalInfo object currently specified in a third-party extension of OMERO.server. Although discussions have started to ship this extension and make it a first-class citizen, it is not a core OMERO concept yet. In that sense, modifying OMERO.web to support it natively feels premature and creates a precedent. |
|
Thanks @sbesson, I had added the latest state to the description, including screenshots. But I can tidy up the text and remove older screenshots (maybe I'll move them to a later comment to keep them for comparison). Is it the display of The display of The test to check whether the Even though omero-zarr-pixel-buffer is not shipped with OMERO yet, it's adoption is significant and those using it would find it very useful to be able to see the The way that we display @dominikl is the best person from IDR to review this. |
|
👍 Thanks Will! I'd really like to have this PR in asap :-) If you have an ome.zarr which for some reason doesn't work as expected, then it is really painful to inspect the ExternalInfo at the moment. I know, for the user currently it is not of much direct value, but wrt to IDR it will be when we update to the http:// URLs (even now there are probably applications which could take the s3:// URL too). I don't really see what the problem is with "exposing" something from the ExternalInfo, it is accessible anyway via API, there's nothing hidden/secret there, is it? |
|
I opened a PR against this branch at will-moore#4 to illustrate how we could separate the display of external info and allowing project or installation specific customizations for Zarr or other formats that may be linked via external info. |
Make external info display generic and add templating blocks for customization
sbesson
left a comment
There was a problem hiding this comment.
Thanks @knabar, the latest changes included in this contribution address the concerns I raised in a previous comment These changes expose the ExternalInfo metadata associated with several objects, primarily Image but also Project and Dataset, in the right-hand panel of the OMERO.web UI. In addition, the templates are made extensible so that an installation can customize their appearance following per the standard OMERO.web customization principles.


Since we and others are starting to use externalInfo for OME.zarr data it is useful to display this in web. Glencoe already use this.
Zarrbutton in the right panel toolbar if the externalInfo is found (and if it has entityType ofcom.glencoesoftware.ngff:multiscales) - see discussion below.externalInfoif needed.Zarr button:
Click to show:
with details expanded...
cc @knabar @dominikl