Replace "...examples" with docker-example-omero and add prod-playbooks#7
Merged
lubianat merged 1 commit intoome:masterfrom Dec 18, 2025
Merged
Conversation
Member
Author
|
Sorry, I wanted to ask @lubianat for a review, but somehow I do not see him on the list in the Reviewers. Maybe @joshmoore or @jburel could help please ? Also, the tests are passing for me on my fork https://github.com/pwalczysko/status/actions, but did not start with opening of this PR. |
Member
Author
|
I belive the tests are starting at 6 am every day as per but only frommaster.
Would you be happy for me to merge my PR and see what happens ? |
Member
Had to assign this repo to the gerbi team. 👍 |
lubianat
approved these changes
Dec 18, 2025
Contributor
lubianat
left a comment
There was a problem hiding this comment.
looks good
it may be a good option to set some kind of PR preview here, but I'll tackle that in a different issue
Contributor
|
I'll just merge it and run the workflow manually for now. |
Member
Author
|
Thank you @lubianat and @joshmoore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lubianat @joshmoore @jburel @Rdornier
First of all, thanks @lubianat for the very nice dashboard here.
The present PR is suggesting to restructure the ansible-docker section, in lines with comment at ome/docker-example-omero#21 (comment) - in a nutshell:
There are quite a few repos in https://github.com/ome/omero-deployment-examples the maintenance of which is unclear and unallocated (and quite frankly, for most of them not happening for quite a while). This was discussed with @jburel and we agree that only one will be supported/maintained going ahead. I would suggest 1 for docker and 1 for ansible.
For docker: the docker-example-omero
For ansible: prod-playbooks == the main public ansible playbooks repo which is being actively maintained (the GHA is running and green there, and the playbook is also tested manually during OME Teams prod server deployments)
The present PR is trying to reflect this ^^^ suggestion.