Remove EPosition auth requirement from FlowALP beta cap transactions#175
Merged
jordanschalm merged 10 commits intomainfrom Mar 26, 2026
Merged
Remove EPosition auth requirement from FlowALP beta cap transactions#175jordanschalm merged 10 commits intomainfrom
jordanschalm merged 10 commits intomainfrom
Conversation
…uthorized withdrawals The beta capability was granting both EParticipant and EPosition entitlements, which gave any beta user direct access to pool-level withdraw, withdrawAndPull, depositAndPush, lockPosition, unlockPosition, and borrowPosition methods. This allowed withdrawals from any user's position by ID. Beta users only need EParticipant (createPosition, depositToPosition) for normal operations. This removes EPosition from both the publish and claim transactions and their test copies. https://claude.ai/code/session_011G8tWcco9U7kPvNbf5kLgc
loic1
reviewed
Feb 19, 2026
Collaborator
loic1
left a comment
loic1
left a comment
There was a problem hiding this comment.
I think create position tx and create position not managed tx need to be updated too
https://github.com/onflow/FlowALP/blob/main/cadence/transactions/flow-alp/position/create_position.cdc#L79
turbolent
reviewed
Feb 19, 2026
cadence/tests/transactions/flow-alp/beta/claim_and_save_beta_cap.cdc
Outdated
Show resolved
Hide resolved
EPosition is an internal-only entitlement that should never be granted to external users. Replace with EParticipant (for position creation) or ERebalance (for rebalancing) as appropriate. Update adversarial reentrancy test connector to use EParticipant and depositToPosition instead of withdrawAndPull. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update AdversarialReentrancyConnectors to hold a PositionManager capability instead of a Pool capability. The adversarial source now attempts a reentrant withdrawal through the Position resource, which is the realistic attack vector since external users access positions through PositionManager, not the Pool directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jordanschalm
commented
Feb 19, 2026
cadence/tests/transactions/flow-alp/pool-management/03_grant_beta.cdc
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastian Müller <bastian@turbolent.com>
Member
Author
👍 There were a few others too. Conceptually, |
6 tasks
Conflicts: cadence/contracts/FlowALPv0.cdc cadence/tests/contracts/AdversarialReentrancyConnectors.cdc cadence/tests/transactions/flow-alp/beta/claim_and_save_beta_cap.cdc cadence/tests/transactions/flow-alp/beta/publish_beta_cap.cdc cadence/tests/transactions/flow-alp/pool-management/03_grant_beta.cdc cadence/tests/transactions/flow-alp/pool-management/04_create_position.cdc cadence/tests/transactions/position-manager/create_position_reentrancy.cdc cadence/tests/transactions/position-manager/create_position_spoofing_source.cdc cadence/transactions/flow-alp/beta/claim_and_save_beta_cap.cdc cadence/transactions/flow-alp/beta/publish_beta_cap.cdc cadence/transactions/flow-alp/pool-management/rebalance_position.cdc cadence/transactions/flow-alp/position/create_position.cdc cadence/transactions/flow-alp/position/create_position_not_managed.cdc
…t exposing EPosition Resolves conflicts from merging main into the EPosition removal branch. Entitlements now reference FlowALPModels (main's refactor) while keeping EPosition out of all user-facing beta capabilities (this branch's fix). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Conflicts: cadence/tests/transactions/flow-alp/beta/claim_and_save_beta_cap.cdc cadence/tests/transactions/flow-alp/beta/publish_beta_cap.cdc cadence/tests/transactions/flow-alp/pool-management/04_create_position.cdc
m-Peter
approved these changes
Mar 26, 2026
Collaborator
m-Peter
left a comment
m-Peter
left a comment
There was a problem hiding this comment.
Looks solid 👏
EPosition has been replaced by either EParticipant or ERebalance, but I think a few tests are now failing due to this replacement.
tim-barry
approved these changes
Mar 26, 2026
Collaborator
tim-barry
left a comment
tim-barry
left a comment
There was a problem hiding this comment.
LGTM; seems the failing tests are ones marked related to the over-grant of capabilities, which should no longer be an issue after the changes made in this PR. We probably want to remove those tests, and may also want to add additional capability tests to ensure users aren't granted EPosition.
… test Remove EPosition and EParticipantPosition test sections from cap_test.cdc since EPosition-entitled pool capabilities are not used. Fix flaky test_supervisor_stale_uuid_does_not_panic by letting the initial cron tick fire before setting up stale state, avoiding a race with the scheduler. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
FlowALPv0.EPositionauthorization requirement from all FlowALP transactions. This should have been done while implementing per-position positions in #130.This PR also re-works the
AdversarialReentrancyConnectors, which are used in testing. Previously they used theEPositionentitlement; here they are changed to use aPositionresource.https://claude.ai/code/session_011G8tWcco9U7kPvNbf5kLgc