add more evm state helpers tests#241
Open
zhangchiqing wants to merge 2 commits intofeature/forked-simulationsfrom
Open
add more evm state helpers tests#241zhangchiqing wants to merge 2 commits intofeature/forked-simulationsfrom
zhangchiqing wants to merge 2 commits intofeature/forked-simulationsfrom
Conversation
zhangchiqing
commented
Mar 31, 2026
| tokenAAddress: wflowAddress, | ||
| tokenBAddress: pyusd0Address, | ||
| fee: univ3PoolFee, | ||
| priceTokenBPerTokenA: 1.0, |
Member
Author
There was a problem hiding this comment.
Looking at the usages in forked_rebalance_***_test.cdc, the reverse is often set to false, and setPoolToPrice is often set with
a price that has been adjusted, so that when swapping again, the actual price with fee included could be exactly equal to the
price value passed in: setPoolToPrice(priceTokenBPerTokenA: feeAdjustedPrice(price, fee: 100, reverse: false).
We should have different test cases covering these actual usages.
That's why I'm adding some test cases in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #???
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer