Avoid requiring unnecessary hex-encoding and using decodeHex#18
Open
Avoid requiring unnecessary hex-encoding and using decodeHex#18
Conversation
|
maybe we can make this non-breaking by checking: prepare(signer: AuthAccount) {
signer.contracts.add(name: name, code: code.utf8.contains(32) ? code.utf8 : code.decodeHex())
} |
6 tasks
|
probably some alternative method that uses utf8 string instead of hex could help avoid breaking changes? |
this seems a bit confusing to me but would be happy to see other inputs :) |
|
Basically it is checking if there is space character in code, if there is space, it means we sent a String without hex encoding (so we use .utf8 ), if there is no space, we sent hex encoded (so we use decodeHex). ( as we cannot create a contract code without spaces ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17