Add IdentityFixPass to fix invalid graphs with direct input-output connections #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONNX specification prohibits graph inputs from being directly used as graph outputs without intermediate nodes. This creates invalid graphs that fail validation.
Changes
New pass:
IdentityFixPassinsrc/onnx_ir/passes/common/identity_fix.pyis_graph_input())Tests: 12 test cases in
identity_fix_test.pycovering:Export: Added to
__init__.pyfor public APIUsage
Ref: pytorch/pytorch#167848
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.