Update dependencies to latest stable versions #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update github.com/stolostron/cluster-lifecycle-api to latest main branch (v0.0.0-20251028083736-64a17b44b598) - Update open-cluster-management.io/addon-framework to v1.1.1 (latest stable) - Update open-cluster-management.io/api to v1.1.0 (latest stable) - Update open-cluster-management.io/sdk-go to v1.1.0 (latest stable) - Update github.com/openshift/library-go to v0.0.0-20250711143941-47604345e7ea These dependency updates introduced API changes that required code updates: 1. CSRConfigurationsFunc signature now requires ManagedClusterAddOn parameter and returns error - Updated pkg/proxyagent/agent/agent.go (line 95) - Updated test in pkg/proxyagent/agent/agent_test.go (line 422) 2. CSRSignerFunc signature now requires cluster and addon parameters and returns error - Updated CustomSignerWithExpiry function in pkg/proxyagent/agent/agent.go (line 363) - Updated test in pkg/proxyagent/agent/agent_test.go (line 441) 3. NewInMemoryRecorder now requires PassiveClock parameter - Updated pkg/proxyserver/controllers/managedproxyconfiguration_controller.go (line 73) - Added k8s.io/utils/clock import All tests pass and the build succeeds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: xuezhaojun <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 13.84% 13.84%
=======================================
Files 39 39
Lines 2254 2254
=======================================
Hits 312 312
Misses 1913 1913
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xuezhaojun
merged commit 30c62d2
into
open-cluster-management-io:main
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates all project dependencies to their latest stable versions:
Changes Required
The dependency updates introduced breaking API changes that required code fixes:
CSRConfigurationsFunc signature change: Now requires ManagedClusterAddOn parameter and returns error
CSRSignerFunc signature change: Now requires cluster and addon parameters and returns error
NewInMemoryRecorder signature change: Now requires PassiveClock parameter
Test Plan
make test)make build)make verify)🤖 Generated with Claude Code