Remove unused DumpSecret function from selfsigned package #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DumpSecret function is no longer used anywhere in the codebase. This cleanup removes the unused code to maintain code quality. Signed-off-by: xuezhaojun <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 13.84% 13.92% +0.08%
==========================================
Files 39 39
Lines 2254 2241 -13
==========================================
Hits 312 312
+ Misses 1913 1900 -13
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
/lgtm |
openshift-merge-bot
bot
merged commit 179dfc0
into
open-cluster-management-io:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the unused
DumpSecretfunction from the selfsigned authentication package. The function was not being used anywhere in the codebase and has been replaced by more appropriate alternatives.Changes
DumpSecretfunction that acceptedcontroller-runtimeclientsigs.k8s.io/controller-runtime/pkg/clientMotivation
Code cleanup to remove dead code and reduce maintenance burden.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]