Skip to content

Conversation

@martacki
Copy link

@martacki martacki commented Nov 26, 2025

Changes proposed in this Pull Request

push all settings that never change between scenarios & validation to config.default so that the scenarios are clean and changes become more visible (keep relevant setting in configs, even if they don't change)

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • OET SPDX license header added to all touched files.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.
  • I will remember to squash merge the PR.

500.: Al/St 240/40 4-bundle 380.0
750.: Al/St 560/50 4-bundle 750.0
s_max_pu: 0.7
s_max_pu: 1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s_max_pu = 1.0 and using the maximum flow as value for s_nom?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using the NTC, exactly

hac_features:
- wnd100m
- influx_direct
exclude_carriers: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have to remove this. Other configs just change this line, but probably it was a mistake deleting it here; good catch!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah no actually it's correct- added a list of carriers to be excluded below

* add CCL constraint for heat pumps modelled as links

* overwrite aggpnomminmax with dummy data for heat pump minmax constraints

* add required config changes

* remove efficiency

* remove efficiency

* back to 3h resolution

---------

Co-authored-by: Hazem <[email protected]>
@hazemakhalek hazemakhalek merged commit 9ff27bc into future_scenarios Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants