-
Notifications
You must be signed in to change notification settings - Fork 4
reduce config size by putting same settings to default #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 500.: Al/St 240/40 4-bundle 380.0 | ||
| 750.: Al/St 560/50 4-bundle 750.0 | ||
| s_max_pu: 0.7 | ||
| s_max_pu: 1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s_max_pu = 1.0 and using the maximum flow as value for s_nom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using the NTC, exactly
| hac_features: | ||
| - wnd100m | ||
| - influx_direct | ||
| exclude_carriers: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have to remove this. Other configs just change this line, but probably it was a mistake deleting it here; good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah no actually it's correct- added a list of carriers to be excluded below
* add CCL constraint for heat pumps modelled as links * overwrite aggpnomminmax with dummy data for heat pump minmax constraints * add required config changes * remove efficiency * remove efficiency * back to 3h resolution --------- Co-authored-by: Hazem <[email protected]>
Changes proposed in this Pull Request
push all settings that never change between scenarios & validation to config.default so that the scenarios are clean and changes become more visible (keep relevant setting in configs, even if they don't change)
Checklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.doc/data_sources.rst.doc/release_notes.rstis added.