Skip to content

Conversation

@bparks13
Copy link
Member

For all port controllers, if communication lock cannot be acquired add a line with the basic step of "Confirm the headstage port is turned on".

Fixes #496

@bparks13 bparks13 added this to the 0.7.0 milestone Oct 31, 2025
@bparks13 bparks13 requested a review from aacuevas October 31, 2025 14:44
@bparks13 bparks13 self-assigned this Oct 31, 2025
@bparks13 bparks13 requested review from cjsha and removed request for aacuevas October 31, 2025 14:45
Copy link
Collaborator

@aacuevas aacuevas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the manual voltage message, I'd write something like
"If the problem persists, you may need..." or something

Make it clear that port checking should go first. Writing a big value there is dangerous, so we need to make it clear that it's not something to try lightly

@cjsha
Copy link
Member

cjsha commented Nov 3, 2025

imo, the wording should be more severe or suggest more caution than it currently does.

@bparks13 bparks13 requested a review from aacuevas November 24, 2025 16:22
@bparks13 bparks13 merged commit 7d5bf0a into main Nov 24, 2025
8 checks passed
@bparks13 bparks13 deleted the issue-496 branch November 24, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to acquire lock error message

4 participants