Cleans up the verasonics and pala saving - #22
Merged
Conversation
This was referenced Jun 23, 2026
tristan-deep
marked this pull request as ready for review
June 25, 2026 13:29
Contributor
Author
|
@waltsims ready for review |
waltsims
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for both #21 (verasonics) and #12 (pala).
Moved to
_bs100bw_to_iqand lens correction conversion tozea.data.convert.verasonicsin tue-bmd/zea#457.Effectively converts the verasonics lens correction to zea lens correction which then makes
reconstruct.pytrivial again.Also added
zea.init_deviceto all conversion scripts to set the device.Note need to wait until
v0.1.1zea for this to work (currently also fails the tests because it needs tooling fromv0.1.1)TODO:
v0.1.1