Skip to content

Conversation

@zgjja
Copy link

@zgjja zgjja commented Sep 27, 2024

when using modern build system like uv, mmengine cannot use editable install, this PR fix it.

besides, yapf, isort tools can also be replaced by uv in the future for better performance and easier management.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2024

CLA assistant check
All committers have signed the CLA.

@zgjja zgjja force-pushed the main branch 2 times, most recently from 8bad5df to d5fd1b8 Compare October 14, 2025 06:52
@zgjja zgjja changed the title [Bug] Fix a MLflow vis backend bug when the config key is not str [Feat] provide a editable installation way for tools like uv Nov 14, 2025
@zgjja
Copy link
Author

zgjja commented Nov 14, 2025

@HAOCHENYE i think this one can be reviewed.

P.S. ruff may be the better tool for linting when working with uv. popular packages like transformers are using it.

@HAOCHENYE
Copy link
Collaborator

Setuptools may not be the best choice for editable installations due to issues like this: microsoft/pyright#3846.

I'm planning to replace setuptools with hatch. Refactoring mmengine with a new lint config is reasonable, but it will introduce many conflicts with existing PRs. I'll need some time to handle this...

@fanqiNO1
Copy link
Collaborator

Setuptools may not be the best choice for editable installations due to issues like this: microsoft/pyright#3846.

I'm planning to replace setuptools with hatch. Refactoring mmengine with a new lint config is reasonable, but it will introduce many conflicts with existing PRs. I'll need some time to handle this...

Maybe I can also help migrate linting to Ruff—I've recently been using Ruff to format my own development workflow. Although I'm still using setuptools for installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants